Skip to content

Commit ec1c414

Browse files
committed
Merge #440: Remove dynamic jets
2015a7a Remove dynamic jets (ivanlele) Pull request description: After the discussion with stringhandler and the additional information I provided, we agreed to remove the dynamic jets feature. The motivation behind this decision is that integrators can implement their own `JetHinter` at the library level if they need this functionality ACKs for top commit: KyrylR: ACK 2015a7a; successfully ran local tests Tree-SHA512: 758126321b51cd01dc6df57dcef5348e34e5b10bc4f4500d679e02cb6e428e6cc1f5f9ec6dd733703696a9706e4d423427beec1defa2c34e9306c972ed10f643
2 parents 45dbe65 + 2015a7a commit ec1c414

11 files changed

Lines changed: 1 addition & 1099 deletions

File tree

‎.github/workflows/rust.yml‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -107,25 +107,6 @@ jobs:
107107
cargo fuzz run --fuzz-dir fuzz "$target" -- -runs=1
108108
done
109109
110-
ExternalJetLib:
111-
name: External Jet Library
112-
runs-on: ubuntu-latest
113-
steps:
114-
- name: "Checkout repo"
115-
uses: actions/checkout@v4
116-
117-
- name: "Setup cargo-rbmt"
118-
uses: ./.github/actions/setup-rbmt
119-
120-
- name: "Build external jet dylib"
121-
run: cargo rbmt --lock-file existing run --toolchain stable -- build --manifest-path external-jet-lib-example/Cargo.toml --lib
122-
123-
- name: "Build external-lib-consumer binary"
124-
run: cargo rbmt --lock-file existing run --toolchain stable -- build --manifest-path external-jet-lib-example/Cargo.toml --bin external-lib-consumer
125-
126-
- name: "Run external-lib-consumer with compiled dylib"
127-
run: ./target/debug/external-lib-consumer ./target/debug/libexternal_jet_lib_example.so
128-
129110
IntegrationBuild:
130111
name: Compile daemon integration tests - ${{ matrix.os }}
131112
runs-on: ${{ matrix.os }}

‎Cargo.lock‎

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ required-features = ["docs", "serde"]
3232
default = [ "serde" ]
3333
serde = ["dep:serde", "dep:serde_json"]
3434
docs = []
35-
external-jets = []
3635
fmt = []
3736

3837
[dependencies]
@@ -53,7 +52,7 @@ ariadne = "=0.5.0"
5352
getrandom = { version = "0.2", features = ["js"] }
5453

5554
[workspace]
56-
members = ["codegen", "fuzz", "external-jet-lib-example", "bitcoind-tests"]
55+
members = ["codegen", "fuzz", "bitcoind-tests"]
5756

5857
[workspace.metadata.rbmt.toolchains]
5958
nightly = "nightly-2025-08-23"

‎external-jet-lib-example/Cargo.toml‎

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎external-jet-lib-example/README.md‎

Lines changed: 0 additions & 57 deletions
This file was deleted.

0 commit comments

Comments
 (0)