Skip to content

Pure ComfyUI Node Registry nodes missing 'update-state' field — update button never appears - UPDATE: The code fix I tried worked. :) #3220

Description

@seeker-ktf

I have published 2 nodes only through the ComfyUI Registry (not in custom-node-list.json). They install fine but after I updated the registry they never show an update button in the Manager UI, even when a newer version is available on the registry. If I click on "Switch ver" I can select it, but no user is going to find that.

To reproduce:

  1. Publish a node only through the registry (no PR to custom-node-list.json)
  2. Install it through Manager
  3. Publish a new version to the registry
  4. Restart ComfyUI — no update button appears
  5. Hit /customnode/getlist?mode=cache&channel=default — the node has updatable: true but no update-state field

I think that it's because 'update-state' is never updated for CNR nodes. It only updates for custom-node-list nodes. Around line ~3215 where the CNR node is updates 'updatable' bit not 'update-state'

if(nodeItem['update-state'] == "true") {
    nodeItem.action = 'updatable';
}

That last part is a guess but it's different from the part that updates custom-node-list nodes so I took a shot.

Using ComfyUI-Manager 3.0.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions