From 02251f7304413c18cfc8e2c3498c1732fe4101c4 Mon Sep 17 00:00:00 2001
From: James Reategui <JamesReate@users.noreply.github.com>
Date: Fri, 12 Apr 2024 20:43:38 -0400
Subject: [PATCH 1/2] add failing test for honda vin proto7

---
 internal/loggers/vin_logger_test.go | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/internal/loggers/vin_logger_test.go b/internal/loggers/vin_logger_test.go
index 1a13bf63..a153d3fd 100644
--- a/internal/loggers/vin_logger_test.go
+++ b/internal/loggers/vin_logger_test.go
@@ -118,6 +118,18 @@ func Test_extractVIN(t *testing.T) {
 7e82220202020202020`,
 			wantErr: true,
 		},
+		{
+			name: "Mateusz and Steve example VIN UDS, vin_18DB33F1_UDS",
+			hexValue: `|-
+18DAF111101862F19011354A
+18DAF1112136524534483734
+18DAF11122424C3035363039
+18DAF1112337000000555555
+  `,
+			wantVin:         "5J6RE4H74BL056097",
+			wantVinStartPos: 10,
+			wantErr:         false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

From 567511bfb44bf0a40c94ef44775275efa75d2059 Mon Sep 17 00:00:00 2001
From: James Reategui <JamesReate@users.noreply.github.com>
Date: Mon, 15 Apr 2024 10:03:25 -0400
Subject: [PATCH 2/2] notes

---
 internal/loggers/vin_logger_test.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/internal/loggers/vin_logger_test.go b/internal/loggers/vin_logger_test.go
index a153d3fd..46ee0465 100644
--- a/internal/loggers/vin_logger_test.go
+++ b/internal/loggers/vin_logger_test.go
@@ -126,7 +126,8 @@ func Test_extractVIN(t *testing.T) {
 18DAF11122424C3035363039
 18DAF1112337000000555555
   `,
-			wantVin:         "5J6RE4H74BL056097",
+			wantVin: "5J6RE4H74BL056097",
+			// need to use the request pid to help decode to find start position, 354A is start in frame 1, 37 is last byte we want in frame 4, the rest is padding.
 			wantVinStartPos: 10,
 			wantErr:         false,
 		},