From a6afa2569e764e1277c267135805abb22e983447 Mon Sep 17 00:00:00 2001 From: Soumyaranjan Dash Date: Thu, 6 Aug 2026 12:20:21 -1000 Subject: [PATCH 1/2] Humanize the qualityDataObjectKey inventory key The dataset search API now returns qualityDataObjectKey, the object key of the JSON quality data file, alongside the existing PDF qualityReportObjectKey. Give it a human readable name so it is translated in search results and usable as a path interpolation key. Closes #649 --- dkist/utils/inventory.py | 1 + dkist/utils/tests/test_inventory.py | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/dkist/utils/inventory.py b/dkist/utils/inventory.py index 04d4690c3..ace86fe93 100644 --- a/dkist/utils/inventory.py +++ b/dkist/utils/inventory.py @@ -61,6 +61,7 @@ def __missing__(self, key): "averageDatasetSpatialSampling": "Average Spatial Sampling", "averageDatasetTemporalSampling": "Average Temporal Sampling", "qualityReportObjectKey": "Quality Report Filename", + "qualityDataObjectKey": "Quality Data Filename", "inputDatasetParametersPartId": "Input Dataset Parameters Part ID", "inputDatasetObserveFramesPartId": "Input Dataset Observe Frames Part ID", "inputDatasetCalibrationFramesPartId": "Input Dataset Calibration Frames Part ID", diff --git a/dkist/utils/tests/test_inventory.py b/dkist/utils/tests/test_inventory.py index 86c80b366..19547a62f 100644 --- a/dkist/utils/tests/test_inventory.py +++ b/dkist/utils/tests/test_inventory.py @@ -7,18 +7,23 @@ def test_humanize_loop(): inv = { "hasSpectralAxis": True, + "qualityDataObjectKey": "pid_1_123/BDNEK/BDNEK_quality_data.json", "notAKey": "wibble" } new_inv = humanize_inventory(inv) assert "Has Spectral Axis" in new_inv assert "hasSpectralAxis" not in new_inv + assert "Quality Data Filename" in new_inv + assert "qualityDataObjectKey" not in new_inv assert "notAKey" in new_inv old_inv = dehumanize_inventory(new_inv) assert "Has Spectral Axis" not in old_inv assert "hasSpectralAxis" in old_inv + assert "Quality Data Filename" not in old_inv + assert "qualityDataObjectKey" in old_inv assert "notAKey" in old_inv From e9698f73da634792dd83002a9d06209dcb05c1e9 Mon Sep 17 00:00:00 2001 From: Soumyaranjan Dash Date: Thu, 6 Aug 2026 12:20:21 -1000 Subject: [PATCH 2/2] Add changelog entry --- changelog/748.feature.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog/748.feature.rst diff --git a/changelog/748.feature.rst b/changelog/748.feature.rst new file mode 100644 index 000000000..3d5c00126 --- /dev/null +++ b/changelog/748.feature.rst @@ -0,0 +1 @@ +Add a human readable name for the ``qualityDataObjectKey`` inventory key, which is displayed as "Quality Data Filename" and can be used as the ``{quality_data_filename}`` path interpolation key.