Cycles : Simplify transform handling - #7136
Merged
murraystevenson merged 2 commits intoSep 4, 2026
Merged
Conversation
- Remove unreachable code. CameraAlgo never sets `motion_position`, so we don't need to handle the different cases. It's not even clear that the different cases need different handling - I suspect not. - Drop all the sample interpolation stuff. We learned we don't need it when refactoring the object deformation code. - Do scaling and conversion once, instead of repeating for `set_tfm()` and `set_motion()`. - Document weird scaling in Y, which I think should be removable in future.
johnhaddon
force-pushed
the
cyclesTransforms
branch
from
September 3, 2026 11:22
b21bc23 to
7b7c159
Compare
murraystevenson
left a comment
murraystevenson
left a comment
Contributor
There was a problem hiding this comment.
Thanks John, this looks like a great simplification overall. I've noted a pair of subdivision related wrinkles inline, one straightforward, the other a little vexing...
As with object deformation, none of this is necessary now - Cycles happily accepts any number of samples.
murraystevenson
force-pushed
the
cyclesTransforms
branch
from
September 4, 2026 19:47
9a4e0ea to
8b988a2
Compare
murraystevenson
merged commit Sep 4, 2026
1d0c18f
into
GafferHQ:1.7_maintenance
6 of 7 checks passed
github-project-automation
Bot
moved this from Pending Review
to Pending release
in Work in Progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm about to add PointInstancer support for Cycles, which will effectively mean making as many lightweight CyclesObjects as I can each with their own transform. Before doing that, let's simplify the transform handling in general, since it has a lot of cruft that doesn't seem necessary with modern Cycles.
History suggests that when I delete "redundant" code from GafferCycles I usually delete at least one thing that turned out to be necessary. But harking back to similar work for deformation blur, I've rendered a contact sheet showing various numbers of transform segments rendered across all devices and with both meshes and points - all seems to be well there :