Skip to content
This repository was archived by the owner on Dec 31, 2024. It is now read-only.
This repository was archived by the owner on Dec 31, 2024. It is now read-only.

Consider design changes to the vault to make it more modular #13

Description

@GriffGreen

I like the style of vault that dapphub uses: https://github.com/dapphub/ds-vault

They have a system of authorization checks using https://github.com/nexusdev/ds-auth

Their code is poorly commented and difficult to read, but you get the idea. With a series of external calls to short trusted contracts you may be able to better formally verify the contract down the line and it allows for modularity as some people may want some checks and some people may not want it, those decisions can be made when deploying the contract...

The biggest problem is that this creates alot of DELEGATECALLs which costs a lot of gas :-P so it may not be worth it....

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions