Skip to content

feat(networksecurity): promote UllMirroring resources to GA#17773

Merged
SirGitsalot merged 1 commit into
GoogleCloudPlatform:mainfrom
JeriesAk:ull-mirroring-ga
Jun 4, 2026
Merged

feat(networksecurity): promote UllMirroring resources to GA#17773
SirGitsalot merged 1 commit into
GoogleCloudPlatform:mainfrom
JeriesAk:ull-mirroring-ga

Conversation

@JeriesAk
Copy link
Copy Markdown
Contributor

@JeriesAk JeriesAk commented Jun 1, 2026 •
edited by SirGitsalot
Loading

Promote ULL mirroring resources to GA

networksecurity: `google_network_security_ull_mirroring_engine`, `google_network_security_ull_mirroring_collector`, and `google_network_security_ull_mirroring_collector_rule ` resources promoted to GA

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 1, 2026
@github-actions github-actions Bot requested a review from SirGitsalot June 1, 2026 08:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/networksecurity-mirroring and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 4, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1e1a652:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 2850 insertions(+), 22 deletions(-)
google-beta provider View Diff 3 files changed, 22 deletions(-)

Multiple resources added

This PR adds multiple new resources: google_network_security_ull_mirroring_collector, google_network_security_ull_mirroring_collector_rule, google_network_security_ull_mirroring_engine. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@SirGitsalot SirGitsalot added the override-multiple-resources Allow a PR to contain multiple new resources label Jun 4, 2026
@SirGitsalot SirGitsalot added this pull request to the merge queue Jun 4, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 16513a8 Jun 4, 2026
34 of 37 checks passed
This was referenced Jun 4, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SirGitsalot SirGitsalot SirGitsalot approved these changes

Assignees

No one assigned

Labels

override-multiple-resources Allow a PR to contain multiple new resources service/networksecurity-mirroring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeriesAk @modular-magician @SirGitsalot