-
Notifications
You must be signed in to change notification settings - Fork 47
CI: QA Punch List #2232 #2335
Copy link
Copy link
Labels
BuildBuild system, CMake, compiler, or packagingBuild system, CMake, compiler, or packagingCopilotCopilot use indicated by MaintainerCopilot use indicated by MaintainerDocumentationDocumentation-only or documentation-related changeDocumentation-only or documentation-related changeJSONICC JSON parser, config, or round-trip behaviorICC JSON parser, config, or round-trip behaviorQAMaintainer indicates topic of Quality AssuranceMaintainer indicates topic of Quality AssuranceTestingCTest, regression, or test coverageCTest, regression, or test coverageciContinuous integration workflow changesContinuous integration workflow changes
Milestone
Description
Metadata
Metadata
Assignees
Labels
BuildBuild system, CMake, compiler, or packagingBuild system, CMake, compiler, or packagingCopilotCopilot use indicated by MaintainerCopilot use indicated by MaintainerDocumentationDocumentation-only or documentation-related changeDocumentation-only or documentation-related changeJSONICC JSON parser, config, or round-trip behaviorICC JSON parser, config, or round-trip behaviorQAMaintainer indicates topic of Quality AssuranceMaintainer indicates topic of Quality AssuranceTestingCTest, regression, or test coverageCTest, regression, or test coverageciContinuous integration workflow changesContinuous integration workflow changes
Copilot Review #2232
2026-08-27 16:53:31 UTC
Issue 1
#2332 (comment)
This weakens the generated-profile invariant from exactly 135 profiles to merely one.
CreateAllProfiles.shis unchanged and can continue after individual generation failures, so a partial corpus can now pass this workflow and leave JSON round-trip coverage silently missing. Keep the exact count in sync with the generator, as required bydocs/ctest.md:392-400.Issue 2
The new standalone CTest is not added to either the registered-suite catalog in
docs/ctest.mdor the script-based regression catalog in.github/ci/regression/README.md. Both catalogs enumerate comparable focused executables, and the maintainer add-test process requires keeping them current, so this gate will otherwise be undiscoverable from the canonical test documentation.This issue also appears on line 6116 of the same file.
Issue 3
Build/Cmake/Testing/CMakeLists.txt:6116
Removing this expected count lets the Windows profile fixture succeed after generating only a partial corpus. The batch harness already supports EXPECTED_GENERATED_PROFILE_COUNT, and no profile-generator change accompanies this PR, so retain the 135-profile invariant rather than weakening this platform's gate.