docs(agents): add gator launch skill#2203
Conversation
johntmyers
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
pimlock
left a comment
pimlock
left a comment
There was a problem hiding this comment.
🚢
Couple of nits, around how this skill would be included in the context.
drew
added
gator:in-review
PR Review StatusValidation: This is a concentrated repository documentation/agent-skill update for launching supervised OpenShell gator agents, so it is project-valid. Thanks @pimlock, I checked the trigger-scope and intro concerns you raised. The latest commits removed the broad gateway/model trigger wording and trimmed the extra intro, so that feedback appears addressed. Review findings:
Docs: No Fern docs navigation update is needed because this does not change user-facing CLI/API behavior. Next state: |
| openshell --gateway docker-dev sandbox list | ||
| ``` | ||
|
|
||
| Look for names like `gator-pr-<number>-supervised`. If one exists, inspect its log before deleting or relaunching. |
There was a problem hiding this comment.
When I was using this, my gator sandboxes were something like gator-<TIMESTAMP. There was no PR reference. How do we handle those "conflicts"?
Later in this skill we have issue-specific sandbox names. Should those be checked for conflicts too?
There was a problem hiding this comment.
I would imagine you could steer that w/ the local agent using the skill right and it's going to depend on how the local agent names sandboxes or if you want to direct it to a different naming convention. Nothing in a skill is authoritative.
There was a problem hiding this comment.
Maybe as a follow up: What's the "worst" that can happen if multiple agents are looking at the same PR/issue? Their per-sha state is local, correct.
There was a problem hiding this comment.
I would consider that something that should be managed out of a skill and the machinery that we'd use to manage more gators/agents at scale.
| ```bash | ||
| issue_number="<digits-only>" | ||
| [[ "$issue_number" =~ ^[0-9]+$ ]] || { echo "invalid issue number" >&2; exit 1; } | ||
| sandbox_name="gator-issue-${issue_number}-supervised" |
There was a problem hiding this comment.
Are we concerned about conflicts for these too?
There was a problem hiding this comment.
Meaning accidental duplicates or what?
| --from "$tmp_context" \ | ||
| --watch \ | ||
| --background \ | ||
| "Review and monitor PR #${pr_number} through the gator-gate workflow. Scope this invocation only to PR #${pr_number}." |
There was a problem hiding this comment.
Question: Should the "scope this invocation only to PR ... " be the default?
There was a problem hiding this comment.
The default where? It's an example use case in the skill along with others.
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
johntmyers
force-pushed
the
feat/launch-openshell-gator-skill
branch
from
861fbfe to
3b066eb
Compare
drew
removed
the
gator:in-review
4 participants
Summary
Add a main repository skill for launching and supervising OpenShell gator agents through
scripts/agents/run.sh.Related Issue
N/A
Changes
.agents/skills/launch-openshell-gator/SKILL.mdwith preflight, launch, monitoring, restart, and troubleshooting workflows.CONTRIBUTING.mdagent skills inventory.Testing
git diff --checkpassesmise run pre-commitpassesChecklist