Skip to content

馃樁鈥嶐煂笍 Mystery Factor in Gas Estimation Script#123

Description

@JaredBorders

馃搫 Summary

following refers to arbitrum-tutorials/packages/gas-estimation/scripts/exec.ts

After a thorough review of the gas-estimation script tutorial, including an analysis of the commit history and an organization-wide search, I have been unable to locate a clear explanation for why the following variable is multiplied by a factor of 16:

const l1EstimatedPrice = gasEstimateComponents.l1BaseFeeEstimate.mul(16);

I have examined the detailed documentation (馃憦) related to the gas formula and the section titled How do we get all parts of that equation. However, the documentation repeatedly states, "and multiply by 16" without providing a precise explanation for this multiplication.

馃攷 Interpretation

This factor likely pertains to unit conversion, such as converting from units of size to units of gas. However, neither the tutorial nor the repository offers a clear and specific explanation for this multiplication.

馃拪 Remedy

To improve clarity, I suggest the following steps:

  1. Define a constant with a descriptive name for this factor.
  2. Provide sufficient documentation explaining the purpose and usage of the new constant.
  3. Update the detailed documentation within gasEstimator() to reference the factor of 16 and clearly explain its purpose.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions