fix(esp32): deinit BLE before esp_restart() to stop reboot boot-loop (#114)

* fix(esp32): deinit BLE before esp_restart() to stop reboot boot-loop

reboot() (0x000F) and enterDFUMode() called esp_restart() while NimBLE was
still initialized. esp_restart() resets the CPU but NOT the BT controller
hardware, so on the next (software-reset) boot BLEDevice::init()
(ble_init.cpp:255) tries to enable an already-enabled controller and aborts
-> PANIC. The panic is itself a software reset, so the device boot-loops and
only recovers on a physical power cycle (POWERON fully resets the controller).
Observed on esp32-s3-N16R8 (Seeed reTerminal E1003) after Home Assistant sent
0x000F following a config write: crash logged consistently just after "Device
name will be:" and before "Setting BLE MTU", looping until power-cycled.

Pre-existing latent bug (old main had the identical reboot()); triggered by
issuing a reboot command. Unrelated to the config-read ring-drain change.

Fix: add esp32_ble_deinit_before_restart(), mirroring the deep-sleep teardown
in enterDeepSleep() (main.cpp) -- stop advertising, delay, BLEDevice::deinit(true)
(clearAll disables + releases the controller), esp32_ble_clear_handles() -- and
call it before both esp_restart() sites. That clean controller shutdown is why
sleep->wake already re-inits fine; reboot now does the same. NRF paths untouched
(all new code is under #ifdef TARGET_ESP32).

Builds: esp32-s3-N16R8, esp32-c3-N16, nrf52840custom.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(esp32): drop duplicate READ MSD banner in handleReadMSD

CMD_READ_MSD logged "=== READ MSD COMMAND (0x0044) ===" twice per command:
once at the dispatch case (communication.cpp) and again as the first line of
handleReadMSD(). Remove the one inside the handler; the dispatch case still
logs it exactly once. Cosmetic (serial log only), no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: davelee98

src/communication.cpp

@@ -259,7 +259,6 @@ void sendResponse(uint8_t* response, uint16_t len) {
 }
 
 void handleReadMSD() {
-    writeSerial("=== READ MSD COMMAND (0x0044) ===", true);
     uint8_t response[2 + 16];
     uint16_t responseLen = 0;
     response[responseLen++] = RESP_ACK;

src/device_control.cpp

@@ -21,6 +21,8 @@ extern "C" void bootloader_util_app_start(uint32_t start_addr);
 #include <esp_system.h>
 #include "driver/gpio.h"
 #include "esp32-hal-gpio.h"
+#include "ble_init.h"          // BLEDevice/BLEServer/BLEAdvertising aliases + esp32_ble_clear_handles()
+extern BLEServer* pServer;     // defined in main.cpp
 #endif
 
 extern uint8_t rebootFlag;
@@ -108,13 +110,33 @@ void disconnect_callback(uint16_t conn_handle, uint8_t reason) {
     resetPipeWriteState();   // clear any pipe transfer + reorder queue on disconnect
 }
 
+#ifdef TARGET_ESP32
+// Tear NimBLE down before esp_restart(): esp_restart() resets the CPU but NOT the
+// BT controller hardware, so on the next (software-reset) boot BLEDevice::init()
+// tries to enable an already-enabled controller and aborts -> PANIC boot loop that
+// only a physical power cycle clears. Mirrors the deep-sleep teardown in
+// enterDeepSleep() (main.cpp), which is why sleep->wake re-inits cleanly.
+static void esp32_ble_deinit_before_restart() {
+    if (pServer != nullptr) {
+        BLEAdvertising* pAdvertising = pServer->getAdvertising();
+        if (pAdvertising != nullptr) pAdvertising->stop();
+    }
+    delay(200);
+    BLEDevice::deinit(true);      // clearAll: disables + releases the BT controller
+    esp32_ble_clear_handles();
+    delay(100);
+    writeSerial("BLE deinitialized before restart", true);
+}
+#endif
+
 void reboot(){
     writeSerial("=== REBOOT COMMAND (0x000F) ===", true);
     delay(100);
 #ifdef TARGET_NRF
     NVIC_SystemReset();
 #endif
 #ifdef TARGET_ESP32
+    esp32_ble_deinit_before_restart();
     esp_restart();
 #endif
 }
@@ -702,6 +724,7 @@ void enterDFUMode() {
 #ifdef TARGET_ESP32
     writeSerial("ESP32: Rebooting (OTA typically handled via WiFi)", true);
     delay(100);
+    esp32_ble_deinit_before_restart();
     esp_restart();
 #endif
 }