Fix inverted PluginMessageEvent source/target in InitialConnectSessionHandler#1811
Merged
electronicboy merged 1 commit intoMay 28, 2026
Conversation
R00tB33rMan
added a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 28, 2026
…nHandler See: PaperMC#1811 for more information. Co-authored-by: GoldenEdit <45533337+GoldenEdit@users.noreply.github.com>
R00tB33rMan
approved these changes
May 28, 2026
WouterGritter
approved these changes
May 28, 2026
WouterGritter
left a comment
WouterGritter
left a comment
Contributor
There was a problem hiding this comment.
Should be merged asap
electronicboy
approved these changes
May 28, 2026
robinbraemer
added a commit
to minekube/gate
that referenced
this pull request
Jun 2, 2026
…ler (#693) During the initial server connect, plugin messages received from the client were fired with the source and target swapped (source=server, target=player). The message actually flows client->server and is forwarded to the backend, so the source must be the player and the target the server connection, matching the play-phase handler. Ports PaperMC/Velocity#1811.
DartCZ
pushed a commit
to DartCZ/Velocity
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginMessageEventinInitialConnectSessionHandlerso client -> backend plugin messages usesource = playerandtarget = serverConn, matchingClientPlaySessionHandlerandClientConfigSessionHandler.BackendPlaySessionHandler(introduced in Sending PluginMessage to player before he join a server #774), so client messages were exposed to plugins withServerConnectionas the source andPlayeras the target.