PER-10621: use Archivematica thumbnails#1051
Open
cecilia-donnelly wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 52.13% 52.22% +0.09%
==========================================
Files 354 354
Lines 12085 12090 +5
Branches 2181 2186 +5
==========================================
+ Hits 6300 6314 +14
+ Misses 5555 5551 -4
+ Partials 230 225 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
force-pushed
the
per-10621-archivematica-thumbnails
branch
from
June 8, 2026 19:51
46004fa to
309741d
Compare
cecilia-donnelly
changed the title
cecilia-donnelly
force-pushed
the
per-10621-archivematica-thumbnails
branch
2 times, most recently
from
June 8, 2026 21:00
2e54c37 to
b63b1dc
Compare
cecilia-donnelly
marked this pull request as ready for review
June 8, 2026 21:04
cecilia-donnelly
marked this pull request as draft
June 8, 2026 21:13
cecilia-donnelly
force-pushed
the
per-10621-archivematica-thumbnails
branch
from
June 11, 2026 18:30
9ce98b6 to
b071b9e
Compare
cecilia-donnelly
marked this pull request as ready for review
June 11, 2026 20:21
cecilia-donnelly
force-pushed
the
per-10621-archivematica-thumbnails
branch
from
June 11, 2026 20:21
b071b9e to
18db8cd
Compare
Member
Author
|
I think this is ready for review now @slifty -- I would test it on dev. |
There was a problem hiding this comment.
Pull request overview
Updates the web-app’s thumbnail handling to prefer Archivematica’s 256px thumbnails so thumbnails can still render when other sizes are missing, aligning with the post-#923 thumbnail access approach.
Changes:
- Avoids re-queuing thumbnail refreshes when a 256px thumbnail is already present.
- Adjusts Stela record shaping to read thumbnail URLs from a
thumbnailUrlsmap (including256) and maps them ontoRecordVO. - Adds
thumbnail256to the lean whitelist and adds a unit test for the Stela record conversion.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/shared/services/data/data.service.ts | Tweaks missing-thumbnail detection to account for thumbnail256. |
| src/app/shared/services/api/record.repo.ts | Updates Stela record typing and conversion to use thumbnailUrls (including 256). |
| src/app/shared/services/api/record.repo.spec.ts | Adds test coverage for mapping thumbnailUrls onto RecordVO thumb fields. |
| src/app/shared/services/api/base.ts | Adds thumbnail256 to LeanWhitelist so lean responses can include the 256px thumbnail. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Dang here I was ready to hit approve, but at least a few of the things copilot found look legitimate |
aasandei-vsp
requested changes
Jun 17, 2026
cecilia-donnelly
force-pushed
the
per-10621-archivematica-thumbnails
branch
2 times, most recently
from
July 17, 2026 16:08
73eff00 to
6eff793
Compare
Map the 256 size thumbnail from the stela response to the record and folder. Also check for any thumbnail from the data service when deciding whether or not to refresh an item.
cecilia-donnelly
force-pushed
the
per-10621-archivematica-thumbnails
branch
from
July 17, 2026 16:20
6eff793 to
91ecedc
Compare
Member
Author
|
At last I believe this is ready for re-review, @aasandei-vsp ! Sorry for the long wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the 256 size thumbnails wherever possible in the web-app. This is a followup to #923, which changed the way we load thumbnails in general. With this change, thumbnails will appear even if the other sizes are not available.
For thumbnails to appear in the file list, it needs companion PR https://github.com/PermanentOrg/back-end/pull/881. This one alone fixes the thumbnail in the sidebar editing modal.
I tested this by uploading a record on dev, checking to make sure that it got an Archivematica thumbnail (
thumbnail256was not null), then runningupdate record set thumburl200 = null, thumburl500 = null, thumburl1000 = null, thumburl2000 = null where recordid = _ID_OF_NEW_RECORDin the database directly.I mentioned this in the commit message, but I'm not sure this test is particularly useful - I just wanted to guard against a regression here somehow. Suggestions welcome!