Conversation
|
Roger-luo
approved these changes
Sep 20, 2026
Collaborator
There was a problem hiding this comment.
I think this PR is quite straightforward, but at some point we probably need to separate noise instructions from regular gates, because you don't actually need the noise for power estimation.
If we're actually running things in simulation mode, you would expect something to automatically insert the noise instructions as part of the noise modelling.
Roger-luo
added this pull request to stack #225
September 21, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #195 gets merged, we need to rebase this branch with
cc @kaihsin this PR introduces a breaking change in the vihaco-circuit-isa since it adds the enum variants for leakage.