Repository navigation
Fix initial_ctrl! not applying controls to population - #141
Merged
Merged
Conversation
### Summary
Fix `initial_ctrl!` for DE control optimization so that the initial controls from `ini_population` are actually applied to each individual in the population.
### Details
Previously `initial_ctrl!` only updated the local `all_ctrl` array and never wrote back to the `Scheme` objects, so all individuals kept the same `opt.ctrl`. I added a final loop:
```julia
for i = 1:p_num
param_data(scheme[i]).ctrl = all_ctrl[i]
end
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 77.40% 77.54% +0.14%
==========================================
Files 41 41
Lines 5204 5207 +3
==========================================
+ Hits 4028 4038 +10
+ Misses 1176 1169 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
initial_ctrl!for DE control optimization so that the initial controls fromini_populationare actually applied to each individual in the population.Details
Previously
initial_ctrl!only updated the localall_ctrlarray and never wrote back to theSchemeobjects, so all individuals kept the sameopt.ctrl. I added a final loop: