[fm-equalize-value-py-test] numpy not found error

[seanshpark]

Got this error while doing a clean build.

[seanshpark]

while doing #15367

[seanshpark]

build again two or more times, error didn't show up.
tried again after clearing overlay/venv and m-equalize-value-py-test, error didn't reproduce...

guess that test began before full venv was ready..

maybe this

  # Apply fm-equalize
  add_custom_command(OUTPUT ${AFTER_CIRCLE_OUTPUT_PATH} ${AFTER_CIRCLE_PATTERN_PATH}
    COMMAND ${CMAKE_COMMAND} -E env
            PYTHONPATH=${PYTHON_SITE_PACKAGES}
            ${VIRTUALENV}/bin/python ${FM_EQUALIZE_BIN} -i ${OPT_CIRCLE_OUTPUT_PATH}
                                       -o ${AFTER_CIRCLE_OUTPUT_PATH} -f ${AFTER_CIRCLE_PATTERN_PATH}
                                       --fme_detect ${FME_DETECT_BIN} --dalgona ${DALGONA_BIN}
                                       --fme_apply ${FME_APPLY_BIN}
    DEPENDS ${FM_EQUALIZE_BIN} ${OPT_CIRCLE_OUTPUT_PATH} ${FME_APPLY_BIN} ${FME_DETECT_BIN} ${DALGONA_BIN}
    COMMENT "Apply fm-equalize to ${OPT_CIRCLE_OUTPUT_PATH}"
  )

part needs depdency with common_artifacts_deps

[seanshpark]

numpy is installed by default.
reopen or add new issue if error is reproduced.

[seanshpark]

numpy not found error is reproduced in CI when installing numpy is removed

• draft DRAFT upgrade to python 3.10 #15503

and

• [fm-equalize] fm-equalize_unittest fails #15308 may have same root cause

[seanshpark]

reproduced with focal Docker, clean build.

b"terminate called after throwing an instance of 'pybind11::error_already_set'\n what(): ModuleNotFoundError: No module named 'numpy'\n\n

I've uninstalled numpy intentionally.

---

If I change something with

set(PYTHON_SITE_PACKAGES "${NNCC_OVERLAY_DIR}/venv/lib/python${PYTHON_VERSION}/site-packages")

line, then the build is OK afterwards.

to reproduce the error

• delete venv and fm-equalize-value-py-test in build/debug.
• and then cmake configure and build.

guess from what is happening

• first configure cannot find site packages; build fails
• second configure can find site packages as first failed build made it
• but current dependency looks OK and I don't understand the symptom

---

in the first configure run,

  execute_process(
    COMMAND ${VIRTUALENV}/bin/python -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')"
    OUTPUT_VARIABLE PYTHON_VERSION
    OUTPUT_STRIP_TRAILING_WHITESPACE
  )
  message(STATUS "!!! PYTHON_VERSION=${PYTHON_VERSION}")

gives

-- !!! PYTHON_VERSION=

as there is no virtualenv prepared.

COMMAND ${VIRTUALENV}/bin/python -c "import sys; print(f'{sys.version_info.major}. runs in configure step, not in build step. virtual-env is prepared in build step.

[seanshpark]

fixed