From 5b4d848ddc73fc1bfe8060830e958bba00aae521 Mon Sep 17 00:00:00 2001 From: Sanggyu Lee Date: Tue, 11 Nov 2025 16:22:53 +0900 Subject: [PATCH 1/2] [onert] Remove layer_idx from op_attention It removes lyaer_idx from Attention Param. ONE-DCO-1.0-Signed-off-by: Sanggyu Lee --- runtime/onert/core/include/ir/operation/Attention.h | 1 - 1 file changed, 1 deletion(-) diff --git a/runtime/onert/core/include/ir/operation/Attention.h b/runtime/onert/core/include/ir/operation/Attention.h index df5feb09b14..de2efef29aa 100644 --- a/runtime/onert/core/include/ir/operation/Attention.h +++ b/runtime/onert/core/include/ir/operation/Attention.h @@ -43,7 +43,6 @@ class Attention : public Operation struct Param { - int layer_idx; }; public: From 45f5cef702fe1a5c2b35814eac900f369cb19641 Mon Sep 17 00:00:00 2001 From: Sanggyu Lee Date: Thu, 13 Nov 2025 11:33:58 +0900 Subject: [PATCH 2/2] Remove Param struct and repeated public: --- .../onert/core/include/ir/operation/Attention.h | 15 +-------------- runtime/onert/core/src/ir/operation/Attention.cc | 5 ++--- runtime/onert/core/src/loader/CircleLoader.cc | 2 +- 3 files changed, 4 insertions(+), 18 deletions(-) diff --git a/runtime/onert/core/include/ir/operation/Attention.h b/runtime/onert/core/include/ir/operation/Attention.h index de2efef29aa..2ef519441f9 100644 --- a/runtime/onert/core/include/ir/operation/Attention.h +++ b/runtime/onert/core/include/ir/operation/Attention.h @@ -41,23 +41,10 @@ class Attention : public Operation POS = 10, }; - struct Param - { - }; - -public: - Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs, - const Param ¶m); + Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs); -public: void accept(OperationVisitor &v) const override; OpCode opcode() const final { return OpCode::Attention; } - -public: - const Param ¶m() const { return _param; } - -private: - Param _param; }; } // namespace onert::ir::operation diff --git a/runtime/onert/core/src/ir/operation/Attention.cc b/runtime/onert/core/src/ir/operation/Attention.cc index c77f38c29de..d33599ca1ea 100644 --- a/runtime/onert/core/src/ir/operation/Attention.cc +++ b/runtime/onert/core/src/ir/operation/Attention.cc @@ -22,9 +22,8 @@ namespace onert::ir::operation void Attention::accept(OperationVisitor &v) const { v.visit(*this); } -Attention::Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs, - const Param ¶m) - : Operation{OperandConstraint::createExact(11u), inputs, outputs}, _param{param} +Attention::Attention(const OperandIndexSequence &inputs, const OperandIndexSequence &outputs) + : Operation{OperandConstraint::createExact(11u), inputs, outputs} { } diff --git a/runtime/onert/core/src/loader/CircleLoader.cc b/runtime/onert/core/src/loader/CircleLoader.cc index c613003b027..f212826c0e9 100644 --- a/runtime/onert/core/src/loader/CircleLoader.cc +++ b/runtime/onert/core/src/loader/CircleLoader.cc @@ -436,7 +436,7 @@ void CircleLoader::loadAttention(const Operator *op, ir::Graph &subg) loadOperationIO(op, inputs, outputs); - std::unique_ptr new_op(new ir::operation::Attention(inputs, outputs, {})); + std::unique_ptr new_op(new ir::operation::Attention(inputs, outputs)); subg.addOperation(std::move(new_op)); }