Repository navigation
Conversation
Since r15362, Plugin_I18n::get_locales() reads translation progress from the GlotPress tables instead of the translate.wordpress.org API. It runs on every plugin page through the hreflang links, and without the constant those pages die with a fatal error locally. With the production prefix, the shared query filter short-circuits the translate_* queries, so the locales come back empty as they did when the API call failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since r15362 (#1064),
Plugin_I18n::get_locales()reads translation progress straight from the GlotPress tables instead of calling the translate.wordpress.org API. It runs on every plugin page, through the hreflang links inwp_head. The plugin-directory environment never definedGLOTPRESS_TABLE_PREFIX, so every single-plugin page dies locally:This sets the constant to production's
translate_prefix. The sharedmocks/mu-plugins/wporg-query-filter.phpalready short-circuitstranslate_*queries, soget_gp_branch_id()finds no project andget_locales()returns an empty list. That's the same result the old API call gave locally when it failed.No other environment reaches this code.
Testing
npm run plugins:env start, then open any imported plugin, for examplehttp://localhost:8888/akismet/.I verified it by defining the constant in a running environment. Two plugin pages that were failing returned 200, with no PHP fatal and no database error.
Related
The support-forums environment also crashes when it's restarted with a changed config (
--xdebug,--update). That one is a wp-env bug: re-extracting a zipcoredeleteswp-config.php. It's being fixed upstream in WordPress/gutenberg#85235 and needs no change here.🤖 Generated with Claude Code