refactor(webview): use provider identifiers in ApiOptions by WebMad · Pull Request #1146 · Zoo-Code-Org/Zoo-Code

WebMad · 2026-08-05T01:43:37Z

Summary

extract the ApiOptions provider identifier migration from refactor(webview): complete provider identifier migration #1141
replace raw provider string comparisons with centralized providerIdentifiers
add focused interaction coverage for dynamic model refresh, validation, provider routing, Bedrock custom ARN behavior, and advanced settings

Test plan

cd webview-ui && npx vitest run src/components/settings/__tests__/ApiOptions.interactions.spec.tsx (39 tests)
cd webview-ui && pnpm exec eslint --prune-suppressions --max-warnings=0 src/components/settings/ApiOptions.tsx src/components/settings/__tests__/ApiOptions.interactions.spec.tsx
repository pre-commit lint and type checks

Extracted from #1141.

Summary by CodeRabbit

Bug Fixes
- Improved provider-specific settings behavior, including model refreshes, URL handling, validation clearing, routing, and custom model configuration.
- Standardized provider handling for more consistent model selection and advanced settings updates.
- Preserved custom Bedrock model settings and reset invalid model selections appropriately.
Tests
- Added comprehensive coverage for dynamic provider interactions, model switching, validation, custom endpoints, provider-specific settings, and advanced configuration updates.

coderabbitai · 2026-08-05T01:44:23Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

ApiOptions now uses centralized provider identifiers for model loading, validation, provider rendering, routing, and advanced settings. New interaction tests cover dynamic and static providers, Bedrock models, validation, routing, and settings updates.

Changes

ApiOptions provider migration

Layer / File(s)	Summary
Provider identifier routing `webview-ui/src/components/settings/ApiOptions.tsx`	The component uses `providerIdentifiers` for model fetching, Zoo Gateway validation handling, Bedrock model preservation, provider rendering, OpenRouter routing, advanced settings, and custom ARN controls.
Provider behavior coverage `webview-ui/src/components/settings/__tests__/ApiOptions.interactions.spec.tsx`	Tests cover mocked provider rendering, debounced model refreshes, static-provider behavior, canonical provider branches, validation clearing, and OpenRouter routing.
Bedrock and advanced settings coverage `webview-ui/src/components/settings/__tests__/ApiOptions.interactions.spec.tsx`	Tests cover Bedrock model switching, custom ARN visibility, the consecutive mistake limit, and Poe base URL updates.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Zoo-Code-Org/Zoo-Code#1141: Modifies ApiOptions.tsx and adds related interaction tests.
Zoo-Code-Org/Zoo-Code#1143: Canonicalizes provider identifiers in webview settings.
Zoo-Code-Org/Zoo-Code#1109: Replaces provider identifiers with centralized constants.

Suggested reviewers: taltas

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description summarizes the refactor and lists tests, but it omits the required issue link, checklist, and several template sections.	Add the required Closes issue reference, complete the pre-submission checklist, and include the template sections for documentation, snapshots, videos, and additional notes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main refactor to use centralized provider identifiers in ApiOptions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@webview-ui/src/components/settings/__tests__/ApiOptions.interactions.spec.tsx`:
- Around line 9-11: Update useOpenRouterModelProvidersMock to explicitly return
a query-result shape compatible with useOpenRouterModelProviders, including data
typed as Record<string, OpenRouterModelProvider> so mockReturnValue({ data: {
preferred: {} } }) type-checks. Then run the required ESLint command for
ApiOptions.interactions.spec.tsx.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f8bc3ff-e28f-4016-b91c-e2672b7e0d46

📥 Commits

Reviewing files that changed from the base of the PR and between 7918f6b and 63cd8b3.

📒 Files selected for processing (2)

webview-ui/src/components/settings/ApiOptions.tsx
webview-ui/src/components/settings/__tests__/ApiOptions.interactions.spec.tsx

codecov · 2026-08-05T01:46:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

coderabbitai · 2026-08-05T12:25:44Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

… sort

edelauna

Thanks for this - made one change to also replace openrouter string, and added some openai tests.

WebMad requested review from JamesRobert20, edelauna, hannesrudolph, navedmerchant and taltas as code owners August 5, 2026 01:43

coderabbitai Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread webview-ui/src/components/settings/__tests__/ApiOptions.interactions.spec.tsx Outdated

github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 5, 2026

refactor(webview): canonicalize ApiOptions provider identifiers

9dcd2c0

WebMad force-pushed the refactor/api-options-provider-identifiers branch from bf3f914 to 9dcd2c0 Compare August 5, 2026 12:25

github-actions Bot added awaiting-review PR changes are ready and waiting for maintainer re-review and removed awaiting-review PR changes are ready and waiting for maintainer re-review labels Aug 5, 2026

edelauna added 2 commits August 8, 2026 20:10

test(webview): strengthen ApiOptions interaction coverage

d1c2e54

fix(webview): use providerIdentifiers.openrouter in ApiOptions option…

291c4ef

… sort

edelauna approved these changes Aug 8, 2026

View reviewed changes

edelauna enabled auto-merge August 8, 2026 20:12

github-actions Bot removed the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 8, 2026

edelauna added this pull request to the merge queue Aug 8, 2026

Merged via the queue into Zoo-Code-Org:main with commit 1c60627 Aug 8, 2026
16 checks passed

Navigation Menu

Uh oh!

refactor(webview): use provider identifiers in ApiOptions - #1146

refactor(webview): use provider identifiers in ApiOptions#1146
edelauna merged 3 commits into
Zoo-Code-Org:mainfrom
WebMad:refactor/api-options-provider-identifiers

WebMad commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

edelauna left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

WebMad commented Aug 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Aug 5, 2026

Codecov Report

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

edelauna left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WebMad commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading