From 9a94eeb9628014e94ea1b197f3c423c73b0942e0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 17 Aug 2025 22:34:45 +0000 Subject: [PATCH 1/3] Initial plan From b53d03a344767fce47dde6e443e97c4e55cc635f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 17 Aug 2025 22:41:07 +0000 Subject: [PATCH 2/3] Fix sequence player and image viewer menu toggle behavior - Fix SequencePlayer.qml infoButton to properly toggle menu on click - Fix WorkspaceView.qml imageViewer menu button for consistency - Change from always calling open() to conditional toggle logic Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com> --- meshroom/ui/qml/Viewer/SequencePlayer.qml | 2 +- meshroom/ui/qml/WorkspaceView.qml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meshroom/ui/qml/Viewer/SequencePlayer.qml b/meshroom/ui/qml/Viewer/SequencePlayer.qml index 6caf7b226d..c44fbe43ae 100644 --- a/meshroom/ui/qml/Viewer/SequencePlayer.qml +++ b/meshroom/ui/qml/Viewer/SequencePlayer.qml @@ -288,7 +288,7 @@ FloatingPane { text: MaterialIcons.settings font.pointSize: 11 padding: 2 - onClicked: infoMenu.open() + onClicked: infoMenu.visible ? infoMenu.close() : infoMenu.open() checkable: true checked: infoMenu.visible diff --git a/meshroom/ui/qml/WorkspaceView.qml b/meshroom/ui/qml/WorkspaceView.qml index 577f4c9572..a60e7cdf2b 100644 --- a/meshroom/ui/qml/WorkspaceView.qml +++ b/meshroom/ui/qml/WorkspaceView.qml @@ -113,7 +113,7 @@ Item { padding: 2 checkable: true checked: imageViewerMenu.visible - onClicked: imageViewerMenu.open() + onClicked: imageViewerMenu.visible ? imageViewerMenu.close() : imageViewerMenu.open() Menu { id: imageViewerMenu y: parent.height From 436f585c6178e5d2d745a48974d2acae591fdc7d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 17 Aug 2025 22:43:42 +0000 Subject: [PATCH 3/3] Fix additional menu toggle issues across the UI - Fix Application.qml graphEditorMenu toggle - Fix ImageGallery.qml galleryMenu toggle - Fix NodeEditor.qml settingsMenu toggle - Apply consistent toggle pattern across all menu buttons Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com> --- meshroom/ui/qml/Application.qml | 2 +- meshroom/ui/qml/GraphEditor/NodeEditor.qml | 2 +- meshroom/ui/qml/ImageGallery/ImageGallery.qml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meshroom/ui/qml/Application.qml b/meshroom/ui/qml/Application.qml index 74824749ca..21810f4801 100644 --- a/meshroom/ui/qml/Application.qml +++ b/meshroom/ui/qml/Application.qml @@ -1184,7 +1184,7 @@ Page { text: MaterialIcons.more_vert font.pointSize: 11 padding: 2 - onClicked: graphEditorMenu.open() + onClicked: graphEditorMenu.visible ? graphEditorMenu.close() : graphEditorMenu.open() checkable: true checked: graphEditorMenu.visible Menu { diff --git a/meshroom/ui/qml/GraphEditor/NodeEditor.qml b/meshroom/ui/qml/GraphEditor/NodeEditor.qml index 7a43db7f6a..b912a8f01f 100644 --- a/meshroom/ui/qml/GraphEditor/NodeEditor.qml +++ b/meshroom/ui/qml/GraphEditor/NodeEditor.qml @@ -125,7 +125,7 @@ Panel { text: MaterialIcons.more_vert font.pointSize: 11 padding: 2 - onClicked: settingsMenu.open() + onClicked: settingsMenu.visible ? settingsMenu.close() : settingsMenu.open() checkable: true checked: settingsMenu.visible Menu { diff --git a/meshroom/ui/qml/ImageGallery/ImageGallery.qml b/meshroom/ui/qml/ImageGallery/ImageGallery.qml index 751415c2b7..477856f105 100644 --- a/meshroom/ui/qml/ImageGallery/ImageGallery.qml +++ b/meshroom/ui/qml/ImageGallery/ImageGallery.qml @@ -137,7 +137,7 @@ Panel { padding: 2 checkable: true checked: galleryMenu.visible - onClicked: galleryMenu.open() + onClicked: galleryMenu.visible ? galleryMenu.close() : galleryMenu.open() Menu { id: galleryMenu y: parent.height