Skip to content

security: reject symlinks in PR-supplied Firebase preview artifact #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wecbaiyk-blip wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

security: reject symlinks in PR-supplied Firebase preview artifact #3654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions github-actions/previews/upload-artifacts-to-firebase/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,25 @@ runs:
# RISK: The downloaded `unsafe-artifact` is of input category `RISK`.
- name: Extracting workflow artifact into Firebase public directory.
shell: bash
env:
FIREBASE_PUBLIC_DIR: ${{inputs.firebase-public-dir}}
run: |
set -euo pipefail

extractDir="$RUNNER_TEMP/artifact-unpack"
publicDir="$FIREBASE_PUBLIC_DIR"

mkdir -p '${{inputs.firebase-public-dir}}'
mkdir -p "$publicDir"
mkdir -p "$extractDir"

unzip unsafe-artifact.zip -d "$extractDir"
tar -xvzf "$extractDir/deploy-artifact.tar.gz" -C '${{inputs.firebase-public-dir}}'
tar -xzf "$extractDir/deploy-artifact.tar.gz" -C "$publicDir"

symlinks=$(find "$publicDir" -type l)
if [ -n "$symlinks" ]; then
printf '%s\n' "$symlinks" | sed 's/^/ /'
exit 1
fi

- name: Extracting artifact metadata
id: artifact-info
Expand Down
Loading