Correction in the assignment of the limit value of VPCs #13627
Open
GeanJair wants to merge 1 commit into
Open
Conversation
dheeraj12347
left a comment
dheeraj12347
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the change locally.
- Verified that
DomainResponse#setVpcLimit()previously assignednetworkLimitinstead of the providedvpcLimitparameter. - Confirmed that
DomainJoinDaoImplpasses the correctvpcLimitDisplayvalue to this setter, so the fix addresses the root cause. - Checked the surrounding response setters for consistency; the updated implementation now follows the expected setter pattern.
- Built the affected module successfully using
mvn -pl api -am -DskipTests compile.
I wasn't able to complete runtime verification because I don't currently have a local CloudStack runtime environment available.
DaanHoogland
approved these changes
Jul 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13627 +/- ##
============================================
+ Coverage 16.26% 17.11% +0.85%
Complexity 13435 13435
============================================
Files 5667 5262 -405
Lines 500731 467706 -33025
Branches 60803 54905 -5898
============================================
- Hits 81430 80067 -1363
+ Misses 410197 378709 -31488
+ Partials 9104 8930 -174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when listing the domains with the
listDomainsAPI, the VPC (vpclimit) limits displayed the value of the network limits (networklimit). This inconsistency has been corrected, so that the limit of VPCs are displayed correctly.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
Before changes
After changes
How Has This Been Tested?