Commit 6da87f6
test: pin which check decides a planner hook is a hook
9baf121 fixed a bundle setting __datafusion_session_planner__ to None -- a base
class spelling out that its subclasses contribute no planner -- being admitted
as a components bundle and then having its None called: "'NoneType' object is
not callable", naming neither the extension nor the hook. isinstance against
SessionPlannerExportable rejects an attribute bound to None; hasattr does not.
Nothing pinned it. The fix narrows the list in Python, and _commit_extensions
still carries a Rust-side hasattr as a backstop, so two checks exist and only
one decides. Handing _commit_extensions the unfiltered arguments again brings
the failure straight back, and every other test in the file passes while it
does. Verified by reverting the filter: this test is the one that fails.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 97e6315 commit 6da87f6
1 file changed
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1191 | 1191 | | |
1192 | 1192 | | |
1193 | 1193 | | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
1194 | 1220 | | |
1195 | 1221 | | |
1196 | 1222 | | |
| |||
0 commit comments