From 86a8dc235a45d381f0ef12f2f88a93dbf3423338 Mon Sep 17 00:00:00 2001 From: Barak Manos Date: Tue, 16 Dec 2025 23:47:47 +0200 Subject: [PATCH 1/2] Function `isOrderEncodable` should also verify that the order's B value is not zero --- src/utils/encoders.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/utils/encoders.ts b/src/utils/encoders.ts index f98b911..f701e4f 100644 --- a/src/utils/encoders.ts +++ b/src/utils/encoders.ts @@ -71,8 +71,7 @@ export const encodeOrders = ([order0, order1]: [DecodedOrder, DecodedOrder]): [ export const isOrderEncodable = (order: DecodedOrder): boolean => { try { - encodeOrder(order); - return true; + return encodeOrder(order).B > 0; } catch { return false; } From 6b97cc6defab0d1c7b8aa54dce4f6df12056f263 Mon Sep 17 00:00:00 2001 From: Barak Manos Date: Wed, 17 Dec 2025 00:13:18 +0200 Subject: [PATCH 2/2] Fix lint error --- src/utils/encoders.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/encoders.ts b/src/utils/encoders.ts index f701e4f..4ef1340 100644 --- a/src/utils/encoders.ts +++ b/src/utils/encoders.ts @@ -71,7 +71,7 @@ export const encodeOrders = ([order0, order1]: [DecodedOrder, DecodedOrder]): [ export const isOrderEncodable = (order: DecodedOrder): boolean => { try { - return encodeOrder(order).B > 0; + return encodeOrder(order).B > 0n; } catch { return false; }