Skip to content

force to kill instance on windows #108

Description

@pYr0x

i would recommend to force the killing process and use the PID
https://github.com/bitovi/launchpad/blob/master/lib/local/instance.js#L90
should be: command = 'taskkill /f /pid ' + this.id;

on my windows machine the taskkill was not working an node will not exit because a chrome will still exists

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions