Repository navigation
fix(number-input): preserve cursor position when deleting characters - #24028
Conversation
👷 Deploy request for v12-carbon-react pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for v12-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…gn-system#23590) * fix(tabs): correct overflow boundaries and RTL scrolling * fix(tabs): observe stable sizes when updating overflow buttons --------- Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
[AI agent review — Carbon grounded] · Looks Good · Reviewed by: IBM Bob · Commit: 87fbd33 This PR makes NumberInput with type=number render the controlled value prop directly so the cursor position is preserved when deleting characters in the middle of the input, and adds a regression test. No findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24028 +/- ##
==========================================
- Coverage 91.19% 90.49% -0.71%
==========================================
Files 906 814 -92
Lines 81045 78933 -2112
Branches 10692 10269 -423
==========================================
- Hits 73911 71427 -2484
- Misses 6942 7303 +361
- Partials 192 203 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
673775a
|
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Closes #24027
{{short description}}
Changelog
Fixed
NumberInputmoving the cursor to the end of the field after deleting a character in the middle of the input.Testing / Reviewing
12345into a NumberInput.3and the4.backspacetwice.3and the2, and that the input is145.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesFollowed therequired v12 migration documentation
for any code change that affects v12, or struck through this item because
the PR does not affect v12
Addressed any impact on accessibility (a11y)More details can be found in the pull request guide.