From 7ebcc7aff6a871f8a96e155687718fa6515daa33 Mon Sep 17 00:00:00 2001 From: kwy404 Date: Sat, 14 Nov 2026 20:26:20 -0300 Subject: [PATCH 1/3] fix(utilities/date-time-format): cap relative months at 12 relative.format derives months as weeks / 4, so a month is 28 days. The months branch is used up to 364 days, which is 52 weeks, giving 13 months. A date 364 days ago was shown as "13 months ago" and one day later as "1 year ago". Clamp months to the range -12 to 12. Only dates 364 days away change. Signed-off-by: kwy404 --- .../utilities/src/dateTimeFormat/relative-test.js | 12 ++++++++++++ packages/utilities/src/dateTimeFormat/relative.ts | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/utilities/src/dateTimeFormat/relative-test.js b/packages/utilities/src/dateTimeFormat/relative-test.js index d1360add9f97..af225bb2b3dd 100644 --- a/packages/utilities/src/dateTimeFormat/relative-test.js +++ b/packages/utilities/src/dateTimeFormat/relative-test.js @@ -47,6 +47,18 @@ describe(locale, () => { expect(actualOutput).toBe(rtf.format(1, 'weeks')); }); + test(`-364 days → ${rtf.format(-12, 'months')}`, () => { + const date = Date.now() - 1000 * 60 * 60 * 24 * 364; + const actualOutput = relative.format(date, { locale, style }); + expect(actualOutput).toBe(rtf.format(-12, 'months')); + }); + + test(`+364 days → ${rtf.format(12, 'months')}`, () => { + const date = Date.now() + 1000 * 60 * 60 * 24 * 364; + const actualOutput = relative.format(date, { locale, style }); + expect(actualOutput).toBe(rtf.format(12, 'months')); + }); + tests.forEach(([unit, unitsPassed, secondsInUnit]) => { const datePast = Date.now() - 1000 * unitsPassed * secondsInUnit; const expectedPast = rtf.format(unitsPassed * -1, unit); diff --git a/packages/utilities/src/dateTimeFormat/relative.ts b/packages/utilities/src/dateTimeFormat/relative.ts index 6b198c7076de..60d9a10bf00e 100644 --- a/packages/utilities/src/dateTimeFormat/relative.ts +++ b/packages/utilities/src/dateTimeFormat/relative.ts @@ -24,7 +24,9 @@ export function format( const hours = Math.trunc(minutes / 60); const days = Math.trunc(hours / 24); const weeks = Math.trunc(days / 7); - const months = Math.trunc(weeks / 4); + // A month is counted as 4 weeks, which reaches 13 just before a full year, + // so cap it at 12 + const months = Math.max(-12, Math.min(12, Math.trunc(weeks / 4))); const years = Math.trunc(days / 365); if (Math.abs(seconds) < 60) { From 75ea58eace5e89c4a678a7572684c6e12a216992 Mon Sep 17 00:00:00 2001 From: kennylam <909118+kennylam@users.noreply.github.com> Date: Mon, 16 Nov 2026 10:42:16 -0500 Subject: [PATCH 2/3] Apply suggestion from @adamalston Co-authored-by: Adam Alston --- packages/utilities/src/dateTimeFormat/relative.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utilities/src/dateTimeFormat/relative.ts b/packages/utilities/src/dateTimeFormat/relative.ts index 60d9a10bf00e..25ec0fb53acf 100644 --- a/packages/utilities/src/dateTimeFormat/relative.ts +++ b/packages/utilities/src/dateTimeFormat/relative.ts @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2024 + * Copyright IBM Corp. 2024, 2026 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. From 8a5ece2021ca0c86cbf5a471e4eb28b2c0b4409c Mon Sep 17 00:00:00 2001 From: kennylam <909118+kennylam@users.noreply.github.com> Date: Mon, 16 Nov 2026 10:42:26 -0500 Subject: [PATCH 3/3] Apply suggestion from @adamalston Co-authored-by: Adam Alston --- packages/utilities/src/dateTimeFormat/relative-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utilities/src/dateTimeFormat/relative-test.js b/packages/utilities/src/dateTimeFormat/relative-test.js index af225bb2b3dd..7d7e77aaf338 100644 --- a/packages/utilities/src/dateTimeFormat/relative-test.js +++ b/packages/utilities/src/dateTimeFormat/relative-test.js @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2024 + * Copyright IBM Corp. 2024, 2026 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree.