One time AddressableEntity migration at protocol upgrade - #5433
Open
darthsiroftardis wants to merge 17 commits into
Open
One time AddressableEntity migration at protocol upgrade#5433darthsiroftardis wants to merge 17 commits into
darthsiroftardis wants to merge 17 commits into
Conversation
…version # Conflicts: # execution_engine_testing/tests/src/test/explorer/faucet.rs
darthsiroftardis
requested review from
EdHastingsCasperAssociation,
mpapierski and
zajko
July 20, 2026 12:57
zajko
approved these changes
Aug 25, 2026
| for account_key in hash_keys.iter() { | ||
| if let Ok(Some(StoredValue::ContractPackage(_))) = self.tracking_copy.read(account_key) | ||
| { | ||
| println!("migrating {account_key}"); |
| debug!("successfully migrated package") | ||
| } | ||
| Err(tc_error) => { | ||
| error!("unable to migrate package {}", tc_error) |
Contributor
There was a problem hiding this comment.
I think we should fail the whole upgrade procedure at this point
| debug!("successfully migrated account {}", account_hash) | ||
| } | ||
| Err(tc_error) => { | ||
| error!("failed to migrate userland account {}", tc_error) |
Contributor
There was a problem hiding this comment.
I think we should fail the upgrade procedure at this point?
Contributor
Author
There was a problem hiding this comment.
Failing the entire upgrade for either a singular userland account and/or contract felt a little too extreme. So i figured it made sense to log the error and continue with the upgrade
Contributor
Author
|
Yep, addressing comments |
…version # Conflicts: # execution_engine_testing/tests/src/test/explorer/faucet.rs # executor/evm/tests/executor.rs # node/src/components/contract_runtime/tests.rs # storage/src/eip4788.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: