Skip to content

Not following redirects on 307 or 308 HTTP status codes yet #382

Description

@mkreidenweis-schulmngr

This library follows 301 and 302 redirects:

if((response.statusCode == 301 || response.statusCode == 302) && clientOptions.followRedirects && response.headers && response.headers.location) {

However, the code doesn't consider the more modern status codes 307 and 308 yet, which are semantically equivalent, and used by some servers. So actually valid server configurations lead to an InternalOAuthError instead.

Would you mind following the redirects also for 307 and 308?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions