Skip to content

[108] eliminate tests skipping on windows#200

Open
Doldrums wants to merge 2 commits into
cqfn:masterfrom
Doldrums:108-eliminate-tests-skipping-win
Open

[108] eliminate tests skipping on windows#200
Doldrums wants to merge 2 commits into
cqfn:masterfrom
Doldrums:108-eliminate-tests-skipping-win

Conversation

@Doldrums

@Doldrums Doldrums commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

Case is the following:

There are several tests ignored on windows, e.g. test_reads_git_author. These tests are ignored via "skip if Gem.win_platform?" but this makes it very difficult to develop, since you can not run the entire test suite.
Imho these tests should not be ignored and should be fixed.

May notice that there are not much strong differences in the commands for the terminal and Windows console; so we can correct this situation

@Doldrums

Doldrums commented Jun 1, 2022

Copy link
Copy Markdown
Contributor Author

Perhaps more specific comments are needed:

  • the only difference is in the structure of these terminal command tests
  • if you evaluate in detail what is being executed there: the error can only be on set -e
  • The ERRORLEVEL is already set, so there is no need to GOTO a label that sets the ERRORLEVEL.

@yegor256

Copy link
Copy Markdown
Member

@Doldrums can you please first help with this #204?

@Doldrums

Doldrums commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

@yegor256 sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants