From 96ddf82190160b9f93d703e3dbbf1e4edbf9b114 Mon Sep 17 00:00:00 2001 From: Pravus Date: Fri, 3 Jul 2026 01:37:43 +0200 Subject: [PATCH 1/6] removed unneeded test --- .../commands/start/explorer-alpha.spec.ts | 42 ------------------- 1 file changed, 42 deletions(-) diff --git a/test/sdk-commands/commands/start/explorer-alpha.spec.ts b/test/sdk-commands/commands/start/explorer-alpha.spec.ts index b56c391563..594c111b43 100644 --- a/test/sdk-commands/commands/start/explorer-alpha.spec.ts +++ b/test/sdk-commands/commands/start/explorer-alpha.spec.ts @@ -143,48 +143,6 @@ describe('explorer-alpha', () => { }) }) - describe('multiInstance parameter', () => { - it('should include multi-instance parameter when --multi-instance flag is provided', async () => { - const args: any = { - '--multi-instance': true - } - - await runExplorerAlpha(mockComponents, { - cwd: '/test', - realm: 'test-realm', - baseCoords: { x: 0, y: 0 }, - isHub: false, - args - }) - - expect(mockExec).toHaveBeenCalledWith( - '/test', - 'open', - expect.arrayContaining([expect.stringContaining('multi-instance=true')]), - { silent: true } - ) - }) - - it('should not include multi-instance parameter when --multi-instance flag is not provided', async () => { - const args: any = {} - - await runExplorerAlpha(mockComponents, { - cwd: '/test', - realm: 'test-realm', - baseCoords: { x: 0, y: 0 }, - isHub: false, - args - }) - - expect(mockExec).toHaveBeenCalledWith( - '/test', - 'open', - expect.arrayContaining([expect.not.stringContaining('multi-instance')]), - { silent: true } - ) - }) - }) - describe('URL parameter construction', () => { it('should construct URL with all parameters correctly', async () => { const args: any = { From 413be0b63cb24793532db5b768f8a1c692cb00d2 Mon Sep 17 00:00:00 2001 From: Pravus Date: Fri, 3 Jul 2026 02:43:39 +0200 Subject: [PATCH 2/6] update protocol + add test --- .../etc/playground-assets.api.md | 1 + test/ecs/components/Billboard.spec.ts | 23 ++++++++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/packages/@dcl/playground-assets/etc/playground-assets.api.md b/packages/@dcl/playground-assets/etc/playground-assets.api.md index f32ac00a8d..11a36ec1a7 100644 --- a/packages/@dcl/playground-assets/etc/playground-assets.api.md +++ b/packages/@dcl/playground-assets/etc/playground-assets.api.md @@ -2618,6 +2618,7 @@ export namespace PBAvatarShape { // @public (undocumented) export interface PBBillboard { billboardMode?: BillboardMode | undefined; + targetEntity?: number | undefined; } // @public (undocumented) diff --git a/test/ecs/components/Billboard.spec.ts b/test/ecs/components/Billboard.spec.ts index 8185873c39..681cddff63 100644 --- a/test/ecs/components/Billboard.spec.ts +++ b/test/ecs/components/Billboard.spec.ts @@ -7,7 +7,28 @@ describe('Generated Billboard ProtoBuf', () => { const Billboard = components.Billboard(newEngine) testComponentSerialization(Billboard, { - billboardMode: BillboardMode.BM_Y + billboardMode: BillboardMode.BM_Y, + targetEntity: undefined + }) + }) + + it('should serialize/deserialize Billboard with targetEntity', () => { + const newEngine = Engine() + const Billboard = components.Billboard(newEngine) + + testComponentSerialization(Billboard, { + billboardMode: BillboardMode.BM_Y, + targetEntity: 512 + }) + }) + + it('should serialize/deserialize Billboard without targetEntity', () => { + const newEngine = Engine() + const Billboard = components.Billboard(newEngine) + + testComponentSerialization(Billboard, { + billboardMode: BillboardMode.BM_ALL, + targetEntity: undefined }) }) }) From 5c22758049cef26846e8ee174500fa50e55b4454 Mon Sep 17 00:00:00 2001 From: Pravus Date: Wed, 8 Jul 2026 01:35:59 +0200 Subject: [PATCH 3/6] package update and rebuilt snapshots --- package-lock.json | 13 ++++++------- package.json | 2 +- .../playground-assets/etc/playground-assets.api.md | 3 ++- packages/@dcl/sdk-commands/package-lock.json | 8 ++++---- packages/@dcl/sdk-commands/package.json | 2 +- .../development-bundles/static-scene.test.ts.crdt | 6 +++--- .../development-bundles/testing-fw.test.ts.crdt | 6 +++--- .../development-bundles/two-way-crdt.test.ts.crdt | 6 +++--- test/snapshots/package-lock.json | 2 +- .../production-bundles/append-value-crdt.ts.crdt | 6 +++--- test/snapshots/production-bundles/billboard.ts.crdt | 6 +++--- .../production-bundles/cube-deleted.ts.crdt | 6 +++--- test/snapshots/production-bundles/cube.ts.crdt | 6 +++--- test/snapshots/production-bundles/cubes.ts.crdt | 6 +++--- .../production-bundles/pointer-events.ts.crdt | 6 +++--- .../production-bundles/schema-components.ts.crdt | 6 +++--- test/snapshots/production-bundles/ui.ts.crdt | 6 +++--- .../production-bundles/with-main-function.ts.crdt | 6 +++--- 18 files changed, 51 insertions(+), 51 deletions(-) diff --git a/package-lock.json b/package-lock.json index a10fa9df13..856c693856 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "license": "Apache-2.0", "dependencies": { "@actions/core": "^1.10.0", - "@dcl/protocol": "1.0.0-28050011172.commit-c96236d", + "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1", "@dcl/ts-proto": "1.153.0", "@types/fs-extra": "^9.0.12", @@ -580,9 +580,9 @@ } }, "node_modules/@dcl/protocol": { - "version": "1.0.0-28050011172.commit-c96236d", - "resolved": "https://registry.npmjs.org/@dcl/protocol/-/protocol-1.0.0-28050011172.commit-c96236d.tgz", - "integrity": "sha512-Osksqww4UrUaeuCVqUe3G+4qsm4dF6FN3QZFaS9OPazXu46hmEgz3OHsDjq4ehZJLqikyBdjLHIyWglyD4sMpg==", + "version": "1.0.0-28905497157.commit-85548e4", + "resolved": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "integrity": "sha512-UfDXHVXj09zmnlKZR58YjhNVKYD4mAAyGy8iGXntsuxHRoZ1GAY97o24DTt6Nqang7WXHXL2crALoZUxftFBRg==", "license": "Apache-2.0", "dependencies": { "@dcl/ts-proto": "1.154.0", @@ -8382,9 +8382,8 @@ } }, "@dcl/protocol": { - "version": "1.0.0-28050011172.commit-c96236d", - "resolved": "https://registry.npmjs.org/@dcl/protocol/-/protocol-1.0.0-28050011172.commit-c96236d.tgz", - "integrity": "sha512-Osksqww4UrUaeuCVqUe3G+4qsm4dF6FN3QZFaS9OPazXu46hmEgz3OHsDjq4ehZJLqikyBdjLHIyWglyD4sMpg==", + "version": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "integrity": "sha512-UfDXHVXj09zmnlKZR58YjhNVKYD4mAAyGy8iGXntsuxHRoZ1GAY97o24DTt6Nqang7WXHXL2crALoZUxftFBRg==", "requires": { "@dcl/ts-proto": "1.154.0", "protobufjs": "7.2.4" diff --git a/package.json b/package.json index ec776a1e85..dd7037b51f 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues", "dependencies": { "@actions/core": "^1.10.0", - "@dcl/protocol": "1.0.0-28050011172.commit-c96236d", + "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1", "@dcl/ts-proto": "1.153.0", "@types/fs-extra": "^9.0.12", diff --git a/packages/@dcl/playground-assets/etc/playground-assets.api.md b/packages/@dcl/playground-assets/etc/playground-assets.api.md index 11a36ec1a7..0fecc814e0 100644 --- a/packages/@dcl/playground-assets/etc/playground-assets.api.md +++ b/packages/@dcl/playground-assets/etc/playground-assets.api.md @@ -196,7 +196,8 @@ export const AvatarModifierArea: LastWriteWinElementSetComponentDefinition Date: Thu, 9 Jul 2026 00:39:25 +0200 Subject: [PATCH 4/6] updated protocol package --- package-lock.json | 13 +++++++------ package.json | 2 +- packages/@dcl/sdk-commands/package-lock.json | 8 ++++---- packages/@dcl/sdk-commands/package.json | 2 +- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/package-lock.json b/package-lock.json index 856c693856..51b39edfa4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "license": "Apache-2.0", "dependencies": { "@actions/core": "^1.10.0", - "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "@dcl/protocol": "1.0.0-28974105118.commit-a598406", "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1", "@dcl/ts-proto": "1.153.0", "@types/fs-extra": "^9.0.12", @@ -580,9 +580,9 @@ } }, "node_modules/@dcl/protocol": { - "version": "1.0.0-28905497157.commit-85548e4", - "resolved": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", - "integrity": "sha512-UfDXHVXj09zmnlKZR58YjhNVKYD4mAAyGy8iGXntsuxHRoZ1GAY97o24DTt6Nqang7WXHXL2crALoZUxftFBRg==", + "version": "1.0.0-28974105118.commit-a598406", + "resolved": "https://registry.npmjs.org/@dcl/protocol/-/protocol-1.0.0-28974105118.commit-a598406.tgz", + "integrity": "sha512-wUPTxo6Efk/pFenm7rKGiSIlia+m/FeTlICUT2CmJxZwD5XDpsYl8q9szWWccltqeKFP8zrJsOWu2C2gFfCw2Q==", "license": "Apache-2.0", "dependencies": { "@dcl/ts-proto": "1.154.0", @@ -8382,8 +8382,9 @@ } }, "@dcl/protocol": { - "version": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", - "integrity": "sha512-UfDXHVXj09zmnlKZR58YjhNVKYD4mAAyGy8iGXntsuxHRoZ1GAY97o24DTt6Nqang7WXHXL2crALoZUxftFBRg==", + "version": "1.0.0-28974105118.commit-a598406", + "resolved": "https://registry.npmjs.org/@dcl/protocol/-/protocol-1.0.0-28974105118.commit-a598406.tgz", + "integrity": "sha512-wUPTxo6Efk/pFenm7rKGiSIlia+m/FeTlICUT2CmJxZwD5XDpsYl8q9szWWccltqeKFP8zrJsOWu2C2gFfCw2Q==", "requires": { "@dcl/ts-proto": "1.154.0", "protobufjs": "7.2.4" diff --git a/package.json b/package.json index dd7037b51f..a3870200e5 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues", "dependencies": { "@actions/core": "^1.10.0", - "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "@dcl/protocol": "1.0.0-28974105118.commit-a598406", "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1", "@dcl/ts-proto": "1.153.0", "@types/fs-extra": "^9.0.12", diff --git a/packages/@dcl/sdk-commands/package-lock.json b/packages/@dcl/sdk-commands/package-lock.json index 26d5484dab..5e10f7d263 100644 --- a/packages/@dcl/sdk-commands/package-lock.json +++ b/packages/@dcl/sdk-commands/package-lock.json @@ -17,7 +17,7 @@ "@dcl/inspector": "7.34.3", "@dcl/linker-dapp": "0.15.2", "@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be", - "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "@dcl/protocol": "1.0.0-28974105118.commit-a598406", "@dcl/quests-client": "^1.0.3", "@dcl/quests-manager": "^0.1.4", "@dcl/rpc": "^1.1.1", @@ -371,9 +371,9 @@ } }, "node_modules/@dcl/protocol": { - "version": "1.0.0-28905497157.commit-85548e4", - "resolved": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", - "integrity": "sha512-UfDXHVXj09zmnlKZR58YjhNVKYD4mAAyGy8iGXntsuxHRoZ1GAY97o24DTt6Nqang7WXHXL2crALoZUxftFBRg==", + "version": "1.0.0-28974105118.commit-a598406", + "resolved": "https://registry.npmjs.org/@dcl/protocol/-/protocol-1.0.0-28974105118.commit-a598406.tgz", + "integrity": "sha512-wUPTxo6Efk/pFenm7rKGiSIlia+m/FeTlICUT2CmJxZwD5XDpsYl8q9szWWccltqeKFP8zrJsOWu2C2gFfCw2Q==", "license": "Apache-2.0", "dependencies": { "@dcl/ts-proto": "1.154.0", diff --git a/packages/@dcl/sdk-commands/package.json b/packages/@dcl/sdk-commands/package.json index 54d568ecf9..261183bd7b 100644 --- a/packages/@dcl/sdk-commands/package.json +++ b/packages/@dcl/sdk-commands/package.json @@ -14,7 +14,7 @@ "@dcl/inspector": "7.34.3", "@dcl/linker-dapp": "0.15.2", "@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be", - "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "@dcl/protocol": "1.0.0-28974105118.commit-a598406", "@dcl/quests-client": "^1.0.3", "@dcl/quests-manager": "^0.1.4", "@dcl/rpc": "^1.1.1", From 4769e4e166f0741e561a3575058227b9b36f783f Mon Sep 17 00:00:00 2001 From: Pravus Date: Thu, 9 Jul 2026 00:39:28 +0200 Subject: [PATCH 5/6] Revert "removed unneeded test" This reverts commit 96ddf82190160b9f93d703e3dbbf1e4edbf9b114. --- .../commands/start/explorer-alpha.spec.ts | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/test/sdk-commands/commands/start/explorer-alpha.spec.ts b/test/sdk-commands/commands/start/explorer-alpha.spec.ts index 594c111b43..b56c391563 100644 --- a/test/sdk-commands/commands/start/explorer-alpha.spec.ts +++ b/test/sdk-commands/commands/start/explorer-alpha.spec.ts @@ -143,6 +143,48 @@ describe('explorer-alpha', () => { }) }) + describe('multiInstance parameter', () => { + it('should include multi-instance parameter when --multi-instance flag is provided', async () => { + const args: any = { + '--multi-instance': true + } + + await runExplorerAlpha(mockComponents, { + cwd: '/test', + realm: 'test-realm', + baseCoords: { x: 0, y: 0 }, + isHub: false, + args + }) + + expect(mockExec).toHaveBeenCalledWith( + '/test', + 'open', + expect.arrayContaining([expect.stringContaining('multi-instance=true')]), + { silent: true } + ) + }) + + it('should not include multi-instance parameter when --multi-instance flag is not provided', async () => { + const args: any = {} + + await runExplorerAlpha(mockComponents, { + cwd: '/test', + realm: 'test-realm', + baseCoords: { x: 0, y: 0 }, + isHub: false, + args + }) + + expect(mockExec).toHaveBeenCalledWith( + '/test', + 'open', + expect.arrayContaining([expect.not.stringContaining('multi-instance')]), + { silent: true } + ) + }) + }) + describe('URL parameter construction', () => { it('should construct URL with all parameters correctly', async () => { const args: any = { From 5bfa2afc1006c0c0b904b5c2b94b3bbdda0ceca3 Mon Sep 17 00:00:00 2001 From: Pravus Date: Thu, 9 Jul 2026 00:56:15 +0200 Subject: [PATCH 6/6] rebuilt snapshots --- test/snapshots/package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/snapshots/package-lock.json b/test/snapshots/package-lock.json index 7d56a0e3b8..7f74502e94 100644 --- a/test/snapshots/package-lock.json +++ b/test/snapshots/package-lock.json @@ -170,7 +170,7 @@ "@dcl/inspector": "7.34.3", "@dcl/linker-dapp": "0.15.2", "@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be", - "@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz", + "@dcl/protocol": "1.0.0-28974105118.commit-a598406", "@dcl/quests-client": "^1.0.3", "@dcl/quests-manager": "^0.1.4", "@dcl/rpc": "^1.1.1",