From df27daa88bc5ff4cc4fcbca9979daaf446f76a01 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 29 Jun 2026 14:05:35 +0000 Subject: [PATCH 1/4] Remove duplicate [Theory] and [MemberData] from ROSequenceStreamConformanceTests.Seek_PastEnd_ReadReturns0 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> --- .../ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs index adf30c12bed66f..33f32fc05d662b 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs @@ -35,8 +35,6 @@ protected virtual ReadOnlySequence CreateSequence(byte[] data) protected override Task CreateReadWriteStreamCore(byte[]? initialData) => Task.FromResult(null); - [Theory] - [MemberData(nameof(AllSeekModes))] public override async Task Seek_PastEnd_ReadReturns0(SeekMode mode) { await base.Seek_PastEnd_ReadReturns0(mode); From 935dd2dcdf56c543e09f30c2ff19c4c417b96c4a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 30 Jun 2026 09:06:19 +0000 Subject: [PATCH 2/4] Fix trimmed MemberData resolution for System.Memory conformance test classes Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> --- .../NativeReadOnlyMemoryStream.ConformanceTests.cs | 4 +++- .../NativeWritableMemoryStream.ConformanceTests.cs | 4 +++- .../ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs | 3 +++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs index 7101b6e12095e1..b9e8de6dab4532 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.IO; +using System.Collections.Generic; using System.IO.Tests; using System.Threading.Tasks; @@ -9,6 +10,8 @@ namespace System.Memory.Tests { public class NativeReadOnlyMemoryStreamConformanceTests : StandaloneStreamConformanceTests { + public new static IEnumerable AllSeekModes() => StreamConformanceTests.AllSeekModes(); + protected override bool CanSeek => true; protected override bool CanSetLength => false; protected override bool NopFlushCompletesSynchronously => true; @@ -28,4 +31,3 @@ public class NativeReadOnlyMemoryStreamConformanceTests : StandaloneStreamConfor protected override Task CreateReadWriteStreamCore(byte[]? initialData) => Task.FromResult(null); } } - diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs index 1091abfa7e3a36..d7c87ace629bfe 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.IO; +using System.Collections.Generic; using System.IO.Tests; using System.Threading.Tasks; @@ -9,6 +10,8 @@ namespace System.Memory.Tests { public class NativeWritableMemoryStreamConformanceTests : StandaloneStreamConformanceTests { + public new static IEnumerable AllSeekModes() => StreamConformanceTests.AllSeekModes(); + protected override bool CanSeek => true; protected override bool CanSetLength => false; protected override bool NopFlushCompletesSynchronously => true; @@ -36,4 +39,3 @@ public class NativeWritableMemoryStreamConformanceTests : StandaloneStreamConfor } } } - diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs index 33f32fc05d662b..085ac8a9bd100e 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.IO; using System.Buffers; +using System.Collections.Generic; using System.IO.Tests; using System.Threading.Tasks; using Xunit; @@ -10,6 +11,8 @@ namespace System.Memory.Tests { public class ROSequenceStreamConformanceTests : StandaloneStreamConformanceTests { + public new static IEnumerable AllSeekModes() => StreamConformanceTests.AllSeekModes(); + protected override bool CanSeek => true; protected override bool CanSetLength => false; protected override bool NopFlushCompletesSynchronously => true; From 6c772a58ecf39b1c85433776ece9a205ab0e7ace Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 30 Jun 2026 14:19:06 +0000 Subject: [PATCH 3/4] Root StreamConformanceTests for mobile trimming Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com> --- eng/testing/ILLink.Descriptor.StreamConformanceTests.xml | 3 +++ eng/testing/tests.mobile.targets | 1 + .../NativeReadOnlyMemoryStream.ConformanceTests.cs | 3 --- .../NativeWritableMemoryStream.ConformanceTests.cs | 3 --- .../ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs | 3 --- 5 files changed, 4 insertions(+), 9 deletions(-) create mode 100644 eng/testing/ILLink.Descriptor.StreamConformanceTests.xml diff --git a/eng/testing/ILLink.Descriptor.StreamConformanceTests.xml b/eng/testing/ILLink.Descriptor.StreamConformanceTests.xml new file mode 100644 index 00000000000000..a463351bf87227 --- /dev/null +++ b/eng/testing/ILLink.Descriptor.StreamConformanceTests.xml @@ -0,0 +1,3 @@ + + + diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index d38673115d6aa4..3399b49306213d 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -118,6 +118,7 @@ + diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs index b9e8de6dab4532..bf7be7c339020b 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeReadOnlyMemoryStream.ConformanceTests.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.IO; -using System.Collections.Generic; using System.IO.Tests; using System.Threading.Tasks; @@ -10,8 +9,6 @@ namespace System.Memory.Tests { public class NativeReadOnlyMemoryStreamConformanceTests : StandaloneStreamConformanceTests { - public new static IEnumerable AllSeekModes() => StreamConformanceTests.AllSeekModes(); - protected override bool CanSeek => true; protected override bool CanSetLength => false; protected override bool NopFlushCompletesSynchronously => true; diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs index d7c87ace629bfe..a49627cc936864 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/NativeWritableMemoryStream.ConformanceTests.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.IO; -using System.Collections.Generic; using System.IO.Tests; using System.Threading.Tasks; @@ -10,8 +9,6 @@ namespace System.Memory.Tests { public class NativeWritableMemoryStreamConformanceTests : StandaloneStreamConformanceTests { - public new static IEnumerable AllSeekModes() => StreamConformanceTests.AllSeekModes(); - protected override bool CanSeek => true; protected override bool CanSetLength => false; protected override bool NopFlushCompletesSynchronously => true; diff --git a/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs b/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs index 085ac8a9bd100e..33f32fc05d662b 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyBuffer/ReadOnlySequenceStream.ConformanceTests.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.IO; using System.Buffers; -using System.Collections.Generic; using System.IO.Tests; using System.Threading.Tasks; using Xunit; @@ -11,8 +10,6 @@ namespace System.Memory.Tests { public class ROSequenceStreamConformanceTests : StandaloneStreamConformanceTests { - public new static IEnumerable AllSeekModes() => StreamConformanceTests.AllSeekModes(); - protected override bool CanSeek => true; protected override bool CanSetLength => false; protected override bool NopFlushCompletesSynchronously => true; From 60b9a163cfe35300db7c7083ca50550eb5184290 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 30 Jun 2026 15:41:39 +0000 Subject: [PATCH 4/4] Scope StreamConformanceTests trimming descriptor to Apple mobile Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> --- eng/testing/tests.mobile.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 3399b49306213d..657edc71d11c9c 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -118,7 +118,7 @@ - +