fix(oss): add stub config_setting for build-for-distro to fix folly buck2 build#291
Open
ben-- wants to merge 1 commit into
Open
fix(oss): add stub config_setting for build-for-distro to fix folly buck2 build#291ben-- wants to merge 1 commit into
ben-- wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Author
|
Proof that this works is in folly 2542 |
|
The import failed. @ben-- can you rebase and resolve conflicts? |
Contributor
|
@ben-- has updated the pull request. You must reimport the pull request before landing. |
Author
|
This change is unlikely to merge cleanly because it creates OSS stub implementations in antlir/distro/BUCK. Not knowing internal constraints, I can think of two conceptual solutions:
|
OSS-only stub so that selectors referencing antlir//antlir/distro:build-for-distro don't break OSS builds. The constraint is never set in OSS, so this never matches.
Contributor
|
@ben-- has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSS-only stub so that selectors referencing antlir//antlir/distro:build-for-distro don't break OSS builds. The constraint is never set in OSS, so this never matches.