Skip to content

chore(deps): bump golangci/golangci-lint-action from 6.5.2 to 9.2.1#5910

Open
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/github_actions/golangci/golangci-lint-action-9.2.1
Open

chore(deps): bump golangci/golangci-lint-action from 6.5.2 to 9.2.1#5910
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/github_actions/golangci/golangci-lint-action-9.2.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps golangci/golangci-lint-action from 6.5.2 to 9.2.1.

Release notes

Sourced from golangci/golangci-lint-action's releases.

v9.2.1

What's Changed

IMPORTANT: this is the first immutable release.

Changes

Dependencies

Full Changelog: golangci/golangci-lint-action@v9.2.0...v9.2.1

v9.2.0

What's Changed

Changes

... (truncated)

Commits
  • 82606bf chore: prepare release v9.2.1
  • 97c8387 chore: improve workflows (#1394)
  • 28d0a19 build(deps): bump the dependencies group across 1 directory with 2 updates
  • 633fbc7 build(deps): bump github/codeql-action from 4.35.3 to 4.35.4 (#1391)
  • 59f43e2 build(deps): bump github/codeql-action from 4.35.2 to 4.35.3 (#1389)
  • 9eb174e build(deps): bump fast-xml-builder from 1.1.5 to 1.2.0 (#1386)
  • 4f52504 build(deps): bump github/codeql-action from 4 to 4.35.2 (#1384)
  • 6f87dfd docs: update examples
  • c9500d7 chore: improve workflows
  • 03b1faa chore: improve issue templates
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 25, 2026
@fluid-e2e-bot

fluid-e2e-bot Bot commented May 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot dependabot Bot mentioned this pull request May 25, 2026
Closed
@fluid-e2e-bot

fluid-e2e-bot Bot commented May 25, 2026

Copy link
Copy Markdown

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cheyang
cheyang reviewed Jun 11, 2026
View reviewed changes

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: golangci/golangci-lint-action SHA pin update (v6.5.2 -> v9.2.1) in project-check.yml. This is a significant 3-major-version jump (6->9). The current usage (version: latest, args: --timeout 10m --verbose) is basic and likely compatible, but such a large jump warrants maintainer verification that v9's API/defaults haven't introduced breaking behavior. Additionally, the old v6.5.2 uses Node.js 20 which is being deprecated on GitHub Actions (June 16, 2026), so upgrading is advisable. Recommend maintainer confirm v9 compatibility before merging.

@cheyang

cheyang commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

@dependabot rebase

@dependabot
chore(deps): bump golangci/golangci-lint-action from 6.5.2 to 9.2.1
d72b4e5 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.5.2 to 9.2.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@55c2c14...82606bf)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-version: 9.2.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/github_actions/golangci/golangci-lint-action-9.2.1 branch from 849a8fb to d72b4e5 Compare June 11, 2026 09:42
fix: address golangci-lint v2 failures from action upgrade
bc6f664 
- Fix govet: use %s format string for Eventf in juicefs/transform.go
- Fix errcheck: explicitly ignore file.Close error in metadata.go
- Add .golangci.yml to suppress QF/ST1023 style checks and
  errcheck in test files (common Go test patterns)
@sonarqubecloud

sonarqubecloud Bot commented Jun 11, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot AI requested a review from cheyang June 11, 2026 10:17
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.56%. Comparing base (35e26a8) to head (bc6f664).

Files with missing lines Patch % Lines
pkg/ddc/juicefs/transform.go 0.00% 1 Missing ⚠️
pkg/utils/metadata.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5910   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files         479      479           
  Lines       33275    33275           
=======================================
  Hits        21150    21150           
  Misses      10445    10445           
  Partials     1680     1680

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheyang cheyang mentioned this pull request Jun 11, 2026
Open
2 tasks
cheyang
cheyang reviewed Jun 12, 2026
View reviewed changes

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (sha bc6f664)

Thanks for the follow-up commit fixing govet and errcheck issues. However, the lint CI is still failing with ~40 errors (errcheck in test files, QF1008, QF1011, ST1023, etc.).

Root causes

  1. Wrong config key for v2 format - .golangci.yml uses issues.exclude-rules which is the golangci-lint v1 config syntax. In version: "2" config, the correct key is issues.exclusions.rules (nested under linters.exclusions). The errcheck exclusion for _test.go files is silently ignored.

  2. Missing working-directory - The checkout uses a custom GOPATH layout ($GOPATH/src/github.com/fluid-cloudnative/fluid), but the lint action does not specify working-directory, so golangci-lint may not pick up .golangci.yml from the checkout path at all.

  3. Incomplete staticcheck suppressions - QF1008 appears in production code (not just tests), yet the config only disables it globally in the staticcheck settings section. Since that section is also not being read correctly (points 1-2 above), none of the suppressions take effect.

Relationship to PR #5977

PR #5977 addresses all three issues above with the correct v2 config structure and adds working-directory to the action step. That PR explicitly notes it supersedes this one.

Recommendation

This PR should be closed in favor of #5977, which provides a complete and working solution for the same upgrade. If you'd prefer to keep this PR alive, the .golangci.yml needs to be rewritten with the correct v2 schema and the action step needs working-directory.

Verdict: needs-work (lint CI failing, superseded by #5977)

@cheyang

cheyang commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

This PR bumps golangci/golangci-lint-action from v6.5.2 to v9.2.1 and fixes two lint issues. However, PR #5977 by the maintainer covers the same version bump with additional improvements (adds working-directory config, broader lint exclusions). Recommend merging #5977 instead and closing this one.

Verdict: pending — recommend closing in favor of #5977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cheyang