Skip to content

Commit dd94307

Browse files
committed
fix(ui): guard markLineData access with optional chaining in scatter test
Address PR #1671 review feedback (`4590818105`, `4590818117`) by typing `markLineData` as `| undefined` and asserting `markLineData?.[0]?.yAxis` in `scatter_options_builder_test.ts`. TAG=agy CONV=ba8411ef-c093-4f45-950a-b3bc1899268c
1 parent 6924a6b commit dd94307

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

‎cmd/ui/app/common/components/dashboard/scatter_options_builder_test.ts‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,17 +159,19 @@ describe('scatter_options_builder', () => {
159159
expect(seriesArr[2].lineStyle?.color).toBe(XMC_BASELINE_COLOR);
160160

161161
// Verify markLine baseline
162-
const markLineData = seriesArr[3].markLine?.data as Array<{ yAxis: number }>;
163-
expect(markLineData[0].yAxis).toBe(0.7);
162+
const markLineData = seriesArr[3].markLine?.data as Array<{ yAxis: number }> | undefined;
163+
expect(markLineData?.[0]?.yAxis).toBe(0.7);
164164
});
165165

166166
it('should extract valid HLINE series via extractHlineSeries helper', () => {
167167
const hlines = extractHlineSeries(mockSpec.geoms);
168168
expect(hlines.length).toBe(1);
169-
const markLineData = (hlines[0] as LineSeriesOption).markLine?.data as Array<{
170-
yAxis: number;
171-
}>;
172-
expect(markLineData[0].yAxis).toBe(0.7);
169+
const markLineData = (hlines[0] as LineSeriesOption).markLine?.data as
170+
| Array<{
171+
yAxis: number;
172+
}>
173+
| undefined;
174+
expect(markLineData?.[0]?.yAxis).toBe(0.7);
173175
});
174176

175177
it('should ignore geoms with null or undefined yintercept', () => {

0 commit comments

Comments
 (0)