chore: add generation step for commit#13337
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| fi | ||
| - name: Commit and Create PR | ||
| if: steps.detect.outputs.has_changes == 'true' | ||
| if: steps.detect_librarian.outputs.has_changes == 'true' || steps.generate.outputs.has_changes == 'true' |
There was a problem hiding this comment.
can we create 2 separate commits, one for config change, and one for generated code change?
There was a problem hiding this comment.
Hm not sure I follow, the config change one existed previously - I'm just renaming it so it's less confusing. Do you want me to revert the name to detect?
There was a problem hiding this comment.
In the PR that this workflow creates, the code change contains 1) change to librarian.yaml 2) change to generated code. Let's create separate commit for these in the PR.
This can be a follow up.
There was a problem hiding this comment.
oh I see, in the actual workflow itself (I thought you meant in the PR). Got it, I can create a F/U bug for it.
2 participants
Adds a step to generate libraries when changing a librarian.yaml workflow
Fixes #6219