Skip to content

Commit 499044a

Browse files
authored
Fix buffer_view validation tests (#4686)
* bufferView and bufferArrayView tests had invalid checks for the parameter type tests (copypasta)
1 parent a5da757 commit 499044a

2 files changed

Lines changed: 6 additions & 12 deletions

File tree

‎src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,9 @@ g.test('offset_type')
135135
.desc('Validates the offset parameter type')
136136
.params(u => u.combine('type', keysOf(kTypes)))
137137
.fn(t => {
138+
t.skipIfLanguageFeatureNotSupported('buffer_view');
138139
const type = kTypes[t.params.type];
139-
let enables = `enable subgroups;\n`;
140-
if (type.requiresF16()) {
141-
enables += `enable f16;`;
142-
}
140+
const enables = type.requiresF16() ? 'enable f16;' : '';
143141
const wgsl = `
144142
${enables}
145143
@group(0) @binding(0) var<storage> v : buffer;
@@ -158,11 +156,9 @@ g.test('size_type')
158156
.desc('Validates the offset parameter type')
159157
.params(u => u.combine('type', keysOf(kTypes)))
160158
.fn(t => {
159+
t.skipIfLanguageFeatureNotSupported('buffer_view');
161160
const type = kTypes[t.params.type];
162-
let enables = `enable subgroups;\n`;
163-
if (type.requiresF16()) {
164-
enables += `enable f16;`;
165-
}
161+
const enables = type.requiresF16() ? 'enable f16;' : '';
166162
const wgsl = `
167163
${enables}
168164
@group(0) @binding(0) var<storage> v : buffer;

‎src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,9 @@ g.test('offset_type')
129129
.desc('Validates the offset parameter type')
130130
.params(u => u.combine('type', keysOf(kTypes)))
131131
.fn(t => {
132+
t.skipIfLanguageFeatureNotSupported('buffer_view');
132133
const type = kTypes[t.params.type];
133-
let enables = `enable subgroups;\n`;
134-
if (type.requiresF16()) {
135-
enables += `enable f16;`;
136-
}
134+
const enables = type.requiresF16() ? 'enable f16;' : '';
137135
const wgsl = `
138136
${enables}
139137
@group(0) @binding(0) var<storage> v : buffer;

0 commit comments

Comments
 (0)