- Public repo examples -
-Four PRs that passed review and shouldn't have.
+Public pull requests
+Four changes, and what the structure said about them.
- Real public pull requests in Java, Python, TypeScript, and C#. Every one of them looked routine in the file diff, got approved, and quietly moved a boundary somebody will pay for later. Open any of them on GitHub and check what Striff caught for yourself. + Every example below is a real pull request in a public repository. The diagram is + the one Striff drew; the boxed text is what it produced, word for word. Under each + one is the check we ran by hand against both revisions before putting it here — so + you can repeat it rather than take our word for it.
Boundary shifts, duplicated responsibilities, shared hotspots, and the relationships a file diff hides.
++ A structural diff: the components a change touched, and the dependencies between + them at both revisions. Additions in green, removals struck through, and the + relationships that only exist on one side of the change. +
++ Each shows something the file diff cannot: a type's dependents, a loop that closes, + a module boundary crossed by two files, a sentence in a design doc checked against + the code. +
These risks are invisible in a line-by-line diff. They only show up when you look at the change as a dependency graph, the way Striff does on every PR.
++ These four were picked from {prExampleSample.pullRequests} public pull + requests across {prExampleSample.repositories} repositories. {prExampleSample.noFinding} + of them produced no finding at all. Most pull requests do not move the architecture, + and Striff is built to say so quietly. +
The reviews
-What a reviewer would have missed.
+Four public pull requests.
Each example shows the architecture diagram Striff generated and the GitHub Check it posted, exactly what your team would see on their own PRs.
++ Open any diagram and drag it. Open the pull request beside it and read the diff. The + two should agree. +
-
-
-
- {example.language}
- {example.repo}
- {example.pr}
- Public PR
-
-
- {example.prTitle}
- {example.summary}
-
-
-
-
-
- {example.prTitle}
-{example.summary}
-
+
+
+ {example.kindLabel}
+ {example.repo}
+ {example.pr}
+ {example.prState} PR
+
+
+
+
+ {example.prTitle}
+
+
+ {example.lede}
+
-
- {example.metrics.slice(0, 2).map((metric) => (
- {metric}
- ))}
+
+
+
+
+
-
-
-
-
-
-
-
-
- Conversation 22
-
-
-
- Checks 11
-
-
-
- Files changed 17
-
+
+
+ 
+
+
+ Scroll to zoom · Drag to pan
-
-
-
-
-
- striff / architectural-review
- Architectural review completed
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- ))}
+
+ ))}
+
+
+ These are other people's repositories. Nothing here is a judgement about the code or the
+ people who wrote it — it is a record of what a change did to the shape of a codebase, and
+ every one of these pull requests is a perfectly reasonable change to make.
+
+
+
+ + {example.prTitle} + +
+{example.lede}
+
+ striff / architectural-review
-Architectural review completed
- -
- + These are other people's repositories. Nothing here is a judgement about the code or the + people who wrote it — it is a record of what a change did to the shape of a codebase, and + every one of these pull requests is a perfectly reasonable change to make. +
+ +