Skip to content

fix: replace 5 bare except clauses with except Exception #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosenwang1018 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace 5 bare except clauses with except Exception #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opensora/datasets/parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def __call__(

return results

except:
except Exception:
master_workers_queue.put((worker_index, WorkerStatus.Error, None))
raise

Expand Down
2 changes: 1 addition & 1 deletion opensora/datasets/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import dask.dataframe as dd

SUPPORT_DASK = True
except:
except Exception:
SUPPORT_DASK = False

VID_EXTENSIONS = (".mp4", ".avi", ".mov", ".mkv")
Expand Down
2 changes: 1 addition & 1 deletion opensora/models/mmdit/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
_flash_attn_forward as _flash_attn_forward_v3

SUPPORT_FA3 = True
except:
except Exception:
SUPPORT_FA3 = False

from torch import Tensor
Expand Down
2 changes: 1 addition & 1 deletion opensora/models/mmdit/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from flash_attn_interface import flash_attn_func as flash_attn_func_v3

SUPPORT_FA3 = True
except:
except Exception:
SUPPORT_FA3 = False


Expand Down
2 changes: 1 addition & 1 deletion scripts/cnv/shard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import dask.dataframe as dd

SUPPORT_DASK = True
except:
except Exception:
SUPPORT_DASK = False


Expand Down