[JBTM-2361] Remove dependency on test-utils

[jiramigration]

Michael Musgrove opened JBTM-2361 and commented

The benchmark testsuite has a historical dependency on artifact org.jboss.narayana:test-utils which should now be removed.

---

Affects: 5.0.4

[jiramigration]

Michael Musgrove commented

The pull request missed a usage of test-utils (https://github.com/jbosstm/performance/blob/master/narayana/ArjunaJTS/jts/pom.xml#L64)..)

 

There are three tests that use it so those would need porting to use JMH before removing test-utils. 

[jiramigration]

Michael Musgrove commented

The main narayana repo contains a number of performance tests that depend on test-utils and those should be migrated to the performance repo and updated to use JMH. For example:

 

ArjunaCore/arjuna/tests/classes/com/hp/mwtests/ts/arjuna/performance/Performance1.java
ArjunaCore/arjuna/tests/classes/com/hp/mwtests/ts/arjuna/performance/Performance2.java
ArjunaCore/arjuna/tests/classes/com/hp/mwtests/ts/arjuna/performance/Performance3.java
ArjunaCore/arjuna/tests/classes/com/hp/mwtests/ts/arjuna/performance/Performance4.java
ArjunaJTA/jta/tests/classes/com/arjuna/ats/jta/xa/performance/OnePhase2PCPerformanceDefaultUnitTest.java
ArjunaJTA/jta/tests/classes/com/arjuna/ats/jta/xa/performance/OnePhase2PCPerformanceVolatileUnitTest.java
ArjunaJTA/jta/tests/classes/com/arjuna/ats/jta/xa/performance/OnePhasePerformanceDefaultUnitTest.java
ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/commitmarkable/PerformanceTestCommitMarkableResource.java
ArjunaJTS/jts/tests/classes/com/hp/mwtests/ts/jts/local/synchronizations/Performance.java
ArjunaJTS/jts/tests/classes/com/hp/mwtests/ts/jts/remote/hammer/GridWorker.java
ArjunaJTS/jts/tests/classes/com/hp/mwtests/ts/jts/remote/hammer/PerfHammer.java
rts/at/tx/src/test/java/org/jboss/jbossts/star/test/PerformanceTest.java
tools/src/main/java/io/narayana/perf/PerformanceProfileStore.java

plus quite a few more (search for Measurement or remove the dependency on test-utils to see which tests no long compile.

[jiramigration]

Tom Jenkinson commented

Although this issue has a fix version set, as the issue is not fully complete at least a second fix version can be expected to be added