Configurable setting if arguments and result should be destructured (serialized)

[zamiramos]

Consider to serialize the arguments/result using Newtonsoft.Json instead of toString().

[johanclasson]

Thanks for your input.

Serilog has built in support for doing this, so there is no need to use any third party library for serialization...

I have turned off serialization of arguments and results for performance reasons. At present this behavior is not configurable.

If we implement configurable serialization of arguments and results (just yes or no), what do you think should be the default? To serialize or not?

Would one like to have different settings on different methods?

[zamiramos]

When serialize with Serilog it also consider it as a structure log which is different from a string holding a content of Json structure. That can be cause an issue in some circumstances, for example when using elastic-search as a sink (not all the objects contains the same structure for a single index). As for the default, I think it should not serialize. Regarding the different settings on different methods, I think that it could be useful. Amos. 2017-06-19 12:10 GMT+03:00 Johan Classon <notifications@github.com>:

…

Thanks for your input. Serilog has built in support for doing this, so there is no need to implement any serialization... I have turned off serialization of arguments and results for performance reasons. At present this behavior is not configurable. If we implement configurable serialization of arguments and results (just yes or no), what do you think should be the default? To serialize or not? Would one like to have different settings on different methods? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXwamtiEZPgI_gz1PI20qxrBss_8RbZkks5sFjsKgaJpZM4N95Ad> .