From cdc2600673e4f0472067ea8d0d140e6d7c394358 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Muras?= Date: Wed, 26 Aug 2026 15:15:50 +0200 Subject: [PATCH 1/2] fix: remove `return` in `finally` (PEP 765) from `force_int` and dedupe via `web_utils` --- lib/cuckoo/common/web_utils.py | 6 ++---- web/submission/views.py | 10 +--------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/lib/cuckoo/common/web_utils.py b/lib/cuckoo/common/web_utils.py index e471e0847dd..a9b0a9ff0a6 100644 --- a/lib/cuckoo/common/web_utils.py +++ b/lib/cuckoo/common/web_utils.py @@ -1663,11 +1663,9 @@ def perform_search( def force_int(value): try: - value = int(value) + return int(value) except Exception: - value = 0 - finally: - return value + return 0 def force_bool(value): diff --git a/web/submission/views.py b/web/submission/views.py index 4b081e7affb..6fbe1a9a5e5 100644 --- a/web/submission/views.py +++ b/web/submission/views.py @@ -31,6 +31,7 @@ download_file, download_from_3rdparty, downloader_services, + force_int, get_file_content, load_vms_exits, load_vms_tags, @@ -286,15 +287,6 @@ def __call__(self, func): return self.decorator(func) -def force_int(value): - try: - value = int(value) - except Exception: - value = 0 - finally: - return value - - @conditional_login_required(login_required, settings.WEB_AUTHENTICATION) def index(request, task_id=None, resubmit_hash=None): remote_console = False From 442d8cb97949582db4f665f8e496405877e90ec3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Muras?= Date: Wed, 26 Aug 2026 15:29:47 +0200 Subject: [PATCH 2/2] remove dead code (unused import) --- web/submission/views.py | 1 - 1 file changed, 1 deletion(-) diff --git a/web/submission/views.py b/web/submission/views.py index 6fbe1a9a5e5..3d3819c0dcd 100644 --- a/web/submission/views.py +++ b/web/submission/views.py @@ -31,7 +31,6 @@ download_file, download_from_3rdparty, downloader_services, - force_int, get_file_content, load_vms_exits, load_vms_tags,