Skip to content

[langchain]: Missing docstrings on InMemoryVectorStore public methods #4367

Description

Type of issue

issue / bug

Language

Python

Description

Several public methods in InMemoryVectorStore
(libs/core/langchain_core/vectorstores/in_memory.py) are missing
docstrings while the parent VectorStore class documents them fully.

Methods affected:

  • embeddings
  • delete / adelete
  • add_documents / aadd_documents
  • similarity_search / asimilarity_search
  • similarity_search_with_score / asimilarity_search_with_score
  • similarity_search_by_vector / asimilarity_search_by_vector
  • max_marginal_relevance_search_by_vector
  • max_marginal_relevance_search / amax_marginal_relevance_search
  • from_texts / afrom_texts

I'd like to fix this by opening a PR against langchain-ai/langchain
adding docstrings consistent with the style used in the parent
VectorStore class.

Metadata

Metadata

Assignees

No one assigned

    Labels

    externalUser is not a member of langchain-ailangchainFor docs changes to LangChain

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions