fix(body-reader): do not call sock:receive for reading 0 bytes - #313
Open
Tieske wants to merge 2 commits into
Open
fix(body-reader): do not call sock:receive for reading 0 bytes#313Tieske wants to merge 2 commits into
Tieske wants to merge 2 commits into
Conversation
Contributor
Author
|
note that in the same code, slightly further down; we only read if |
Contributor
Author
|
@pintsized any chance to get this merged? |
pintsized
reviewed
May 19, 2024
Tieske
commented
May 21, 2024
Contributor
|
@Tieske Thanks for your contribution. Hi, I'm a new maintainer and drove the latest 0.18 release. |
Contributor
Author
|
I've just recently looked into this again. And it seems that actually luasocket is at fault. POSIX defines that a 0-byte read should return immediately, which luasocket doesn't do. |
Some sockets can block if called to read 0 bytes until actual bytes are available to read.
Tieske
force-pushed
the
fix/zero-length
branch
from
August 11, 2026 21:36
80f003e to
d77fe00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sockets can block if called to read 0 bytes until actual bytes are available to read.