From 5aad4df5373044803e92cbba6428d183293e32e4 Mon Sep 17 00:00:00 2001 From: Mike Dolan Date: Thu, 16 Jul 2026 11:18:11 -0400 Subject: [PATCH 1/3] Update trade compliance notifications with more accurate status Signed-off-by: Mike Dolan --- .../corporate-dashboard.component.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts b/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts index 6e04bac..d86eda8 100644 --- a/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts +++ b/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts @@ -198,9 +198,9 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { // organization.isSanctioned is typed as a string in the model; normalize so both a // boolean false and a literal "false" are correctly treated as not-flagged. if (String(this.organization.isSanctioned).toLowerCase() === 'true') { - this.title = 'Sanctions Screening'; + this.title = 'Compliance Review Required'; this.message = - 'Heads up: this organization is currently marked as flagged by sanctions screening. We\'ll re-verify in the next step, and if it is still flagged you won\'t be able to acknowledge the ECLA. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; + 'Heads up: this organization currently requires additional trade compliance screening review. We\'ll re-verify in the next step, and if it is still flagged you won\'t be able to acknowledge the CLA. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; this.openWithDismiss(this.warningModal); this.intercomService.show(); } @@ -240,10 +240,10 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { // Authoritative live SSS verdict from check-prepare/request-employee-signature: // the company is currently sanctioned (the persisted flag may have been stale; // this is the live result). Show the dedicated sanctioned message. - this.title = 'Sanctions Screening'; + this.title = 'Compliance Review Required'; this.message = response.errors.description || - 'We\'re sorry, but this organization is flagged by sanctions screening, so the Employee Contributor License Agreement (ECLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; + 'We\'re sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; this.openWithDismiss(this.warningModal); this.intercomService.show(); return; @@ -305,10 +305,10 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { if ( Object.prototype.hasOwnProperty.call(response.errors, 'sanctioned') ) { - this.title = 'Sanctions Screening'; + this.title = 'Review Required'; this.message = response.errors.description || - 'We\'re sorry, but this organization is flagged by sanctions screening, so the Employee Contributor License Agreement (ECLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; + 'We\'re sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; this.openWithDismiss(this.warningModal); this.intercomService.show(); return; @@ -316,7 +316,7 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { this.alertService.error( response.errors.project_id || response.errors.server || - 'Unable to complete the ECLA request.' + 'Unable to complete the CLA request.' ); return; } From 8988b099ac04f500c20a5fc878598f0b1f8d2dab Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 21 Jul 2026 07:23:36 +0000 Subject: [PATCH 2/3] Fix compliance review messaging: use consistent title and remove server description fallback - Remove `response.errors.description ||` from both sanctioned branches so the compliance-review message is always shown, even when the server response includes errors.description - Use 'Compliance Review Required' as title in both branches (was 'Review Required' in postEmployeeSignatureRequest path) - Update inline comments to say 'requires additional trade-compliance review' instead of 'is sanctioned' --- .../corporate-dashboard.component.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts b/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts index d86eda8..c43f2ff 100644 --- a/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts +++ b/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts @@ -238,11 +238,10 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { Object.prototype.hasOwnProperty.call(response.errors, 'sanctioned') ) { // Authoritative live SSS verdict from check-prepare/request-employee-signature: - // the company is currently sanctioned (the persisted flag may have been stale; - // this is the live result). Show the dedicated sanctioned message. + // the company requires additional trade-compliance review (the persisted flag may + // have been stale; this is the live result). Show the dedicated compliance message. this.title = 'Compliance Review Required'; this.message = - response.errors.description || 'We\'re sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; this.openWithDismiss(this.warningModal); this.intercomService.show(); @@ -299,15 +298,14 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { .subscribe( (response: any) => { // /v2/request-employee-signature can return a legacy HTTP-200 body carrying a - // sanctioned block ({code:403, errors:{sanctioned}}) — don't treat every 200 as - // success; mirror the precheck handling so a live sanction still blocks here. + // compliance block ({code:403, errors:{sanctioned}}) — don't treat every 200 as + // success; mirror the precheck handling so a trade-compliance review flag still blocks here. if (response && response.errors) { if ( Object.prototype.hasOwnProperty.call(response.errors, 'sanctioned') ) { - this.title = 'Review Required'; + this.title = 'Compliance Review Required'; this.message = - response.errors.description || 'We\'re sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.'; this.openWithDismiss(this.warningModal); this.intercomService.show(); From 1995767ad4a4a8ead52a9faee4f2a9839d46225d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 21 Jul 2026 09:02:16 +0000 Subject: [PATCH 3/3] Update trade-compliance review comment wording --- .../corporate-dashboard/corporate-dashboard.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts b/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts index c43f2ff..5d88ff5 100644 --- a/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts +++ b/src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts @@ -189,7 +189,7 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy { this.organization ); // Do NOT block on the persisted (possibly stale) isSanctioned flag. If the company is - // currently marked sanctioned, show a non-blocking WARNING but still proceed to the + // currently marked for additional trade-compliance review, show a non-blocking WARNING but still proceed to the // decisive step. checkEmployeeSignature() runs the live SSS check // (/v2/check-prepare-employee-signature), which clears a stale sss-origin block on a // clean result and blocks (errors.sanctioned, handled below) when it is genuinely