Skip to content

Version 1.4 #65

Description

@nida-pyramid

Hi, our project requirement is to use 1.4.1 version, and there I have found a bug.

in file lib/princely/pdf_helper.rb:54

Following method has issue which you guys fixed already in the latest princely version.

Issue: It should do asset.to_s.gsub(".css","")

CURRENT

  def asset_file_path(asset)
    stylesheet = stylesheet.to_s.gsub(".css","")
    File.join(config.stylesheets_dir, "#{stylesheet}.css")
  end

Need to fix this method for version 14.1. Can we change it to below code?

PROPOSED

  def asset_file_path(asset)
    asset = asset.to_s.gsub(".css","")
    File.join(config.stylesheets_dir, "#{asset}.css")
  end

Using for Rails 3.0.0 Version

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions