Skip to content

chore: land 1 reviewed pull request (batch 69) - #12962

Merged
josephfarina merged 2 commits into
mainfrom
josephfarina/land-batch-69
Nov 19, 2026
Merged

josephfarina merged 2 commits into
mainfrom
josephfarina/land-batch-69

Conversation

@josephfarina

Copy link
Copy Markdown
Contributor

Merges this test-data-only pull request onto current main as a merge commit. Nothing else in this batch touches .github/visual-baseline.

The visual baseline is refreshed from main's capture with gate.mjs accept --keys all --prune: 233 shots changed, 24 added and 10 removed. Every shot that moved more than 1% traces to a merged change; the member's description lists them.

Scope

Tests: .github/visual-baseline/ (test data only)

Records

None.

Writing rubric results

No record changes, so R1–R7 do not apply.

When this merges, the pull request above is closed with a note that names this one.

…ry shots, removed stories

From main's canonical capture at ddab5b7. Every shot that moved more than
1% traces to a merged change; 24 shots join for new or newly planned
stories and 10 leave with stories no longer in the plan.
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 19, 2026 5:26pm UTC

Request Review

@astracat-bot

astracat-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 19, 2026, 5:33 PM UTC

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2026
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 5681351

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not finished on this head yet.

This lands #12961's refresh of the stable visual baseline, which is test data only, and the head's shots reproduce its stated counts (233 changed, 24 added, 10 removed), with every shot that moved more than 1% inside the groups it traces to merged changes.

  • After merge, expect shots that render parts restyled on main after the capture (new probe targets for Banner, Pagination and Table states, and a darker placeholder fallback in reset.css) to still show as changed in the visual check until the next refresh.
Claims and files checked

Review mode: full; reason: no-earlier-review

  • Claims:
    • The batch merges the test-data-only pull request onto current main as a merge commit: verified; the head merges main's tip with #12961's head and adds no change of its own.
    • Nothing else in the batch touches .github/visual-baseline: verified; #12961 is the only member, and every changed file is under that directory.
    • The baseline is refreshed from main's capture with gate.mjs accept --keys all --prune: verified; the manifest's new decision promotes all 530 shots and prunes 10 from a successful CI capture dispatched on main.
    • 233 shots changed, 24 were added and 10 were removed: verified with the gate's own comparison settings; 261 files change because --keys all also rewrites 28 shots that moved under the gate's threshold.
    • Every shot that moved more than 1% traces to a merged change that #12961 lists: verified; the 38 such shots fall exactly into its 12 groups, and every cited change is in main's history before the capture.
    • Scope is baseline test data only, with no records: verified; 295 PNGs and the manifest change, and no record does.
    • The member pull request is closed with a note once this merges: not checkable at this head, since it is a post-merge step.
  • Files:
    • .github/visual-baseline/manifest.json: clear.
    • .github/visual-baseline/shots/*.png (261 modified, 24 added, 10 deleted): clear; every head file is a well-formed PNG that matches its manifest hash.

Automated review (maintainer link)

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · 5681351

Storybook · Sandbox · built from this PR's head

Package size: no published package changed; no new dependencies.

Not run on this PR: add ci:run-visual for Visual, ci:run-a11y for Accessibility, ci:run-rtl for RTL.


Generated by PR Enrichment workflow | View full report

@josephfarina
josephfarina merged commit adf405b into main Nov 19, 2026
226 of 244 checks passed

This branch was successfully deployed

1 active deployment
Preview — 56813519 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant