$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

ShpfyTMAReview.Page.al's ApproveReview procedure directly orchestrates multi-step business logic in the page object: it re-applies tax matching (TMAMatcher.ReapplyFromAssignedLines), rebuilds the Tax Area (TaxAreaBuilder.FindOrCreateTaxArea), writes the activity log, flips the reviewed flag, and marks jurisdictions verified, all inline in a page procedure with no codeunit wrapping the sequence. This couples the approval workflow to the UI layer, making it untestable without a page object and harder to reuse from another entry point (e.g. a future bulk-approve action or API).

Recommendation:

• extract the approval sequence into a codeunit procedure that the page calls, keeping the page responsible only for confirmation/UI refresh.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

$\textbf{🟠\ High\ Severity\ —\ Testing}$

The new tests build most fixtures by hand with Init/Insert helpers and invented keys (CreateSalesHeader, CreateConflictScenario, CreateShippingScenario, EnsureItem, EnsureJurisdiction, CreateShop) instead of routing setup through the existing Shpfy TMA Test Library or the standard test library codeunits. That bypasses number-series/validation behavior and duplicates prerequisite setup knowledge, so these tests will become brittle as the Shopify or base-app schemas evolve.

Knowledge:

• microsoft/knowledge/testing/use-library-codeunits-for-test-fixtures.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

$\textbf{🔴\ Critical\ Severity\ —\ AppSource}$

This pageextension adds five new field controls to "Shpfy Shop Card" (owned by the separate "Shopify Connector" app) with unaffixed member names ("Tax Matching Agent Enabled", "Auto Create Tax Jurisdictions", "Auto Create Tax Areas", "Tax Area Naming Pattern", and "Tax Match Review Mode"). AppSource requires extension members added to another app's page to carry the reserved Shpfy affix individually; qualifying only the pageextension object itself is not enough.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

                field(ShpfyTaxMatchingAgentEnabled; Rec."Tax Matching Agent Enabled")
                {
                    ApplicationArea = All;
                }
                field(ShpfyAutoCreateTaxJurisdictions; Rec."Auto Create Tax Jurisdictions")
                {
                    ApplicationArea = All;
                    Enabled = Rec."Tax Matching Agent Enabled";
                }
                field(ShpfyAutoCreateTaxAreas; Rec."Auto Create Tax Areas")
                {
                    ApplicationArea = All;
                    Enabled = Rec."Tax Matching Agent Enabled";
                }
                field(ShpfyTaxAreaNamingPattern; Rec."Tax Area Naming Pattern")
                {
                    ApplicationArea = All;
                    Enabled = Rec."Tax Matching Agent Enabled" and Rec."Auto Create Tax Areas";
                }
                field(ShpfyTaxMatchReviewMode; Rec."Tax Match Review Mode")
                {
                    ApplicationArea = All;
                    Enabled = Rec."Tax Matching Agent Enabled";
                }

Knowledge:

• microsoft/knowledge/appsource/object-affixes-prevent-collisions.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}

$\textbf{🟠\ High\ Severity\ —\ Performance}$

ShpfyTMAOrderTaxLinesPart.OnAfterGetRecord resolves line context and BC rate for every rendered row. That path does Order Line or Shipping Charge lookups, Order Header and Shop Gets, and TryGetEffectiveItemRate's Tax Detail read per row, so the review page scales as N+1 database calls with the number of tax lines. Preload or cache the order context and rate data for the page instead of re-querying per row.

Knowledge:

• microsoft/knowledge/performance/avoid-get-inside-loop-on-large-table.md
• microsoft/knowledge/performance/use-setloadfields-for-partial-records.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.35.4}