Repository navigation
Allow SVG in canBrowserDisplayImage - #26
Merged
Merged
Conversation
3 of 4 tasks
m-mohr
approved these changes
Sep 24, 2026
Collaborator
|
Generally fine, but we may consider the following as SVG seem to have a security problem with scripts potentially and render in a generic (non-size) image tag usually worse than a raster image: stac-js
|
Contributor
Author
|
Done in 9f1ca1d. getThumbnails() now sorts SVG after raster images, and prefers a raster alternate over an SVG asset. |
2 tasks
m-mohr
force-pushed
the
svg-browser-image
branch
from
October 11, 2026 16:38
be75e57 to
0d74adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
image/svg+xmltobrowserImageTypesand treats untyped.svghrefs as images whenallowUndefinedis set. Browsers render SVG in<img>with scripts and external loads blocked, so this is safe.This lets STAC Browser show SVG icons (
getIcons). Note that thumbnails, previews and asset images typedimage/svg+xmlwill now also display.Tests added in
tests/link.test.js,npm run checkpasses.