Skip to content

More subscriptions than permitted by PB_NATS_CLIENT_SUBSCRIPTION_POOL_SIZE #1

Description

@film42

https://github.com/mxenabled/protobuf-nats/blob/master/lib/protobuf/nats/client.rb#L18

Despite a firm limit on subscriptions at 512, we're seeing more than 2k connections.

Saw this opened here but I believe this bug is related to this gem: mperham/connection_pool#170

It's possible subscriptions are leaking out here: https://github.com/abrandoned/protobuf-nats/blob/84d632feb39684358b39727a4d5689c2545d3589/lib/protobuf/nats/client.rb#L245-L248

However, we should rewrite this implementation to use a single subscription like the official request method of the nats libraries.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions